New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvme support for scan #108

Closed
wants to merge 26 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@laser-beans

laser-beans commented Dec 12, 2016

Created method in DevOS that finds block devices in /sys/block matching patterns /dev/sd* and /dev/nvme*. This approach should be more robust, since it will find also find drives that are not consecutive (i.e. /dev/sda and /dev/sdc, skipping /dev/sdb).

@kylemanna

This comment has been minimized.

kylemanna commented May 7, 2017

Any updates on getting this merged? I think this is what I need to get my Dell Precision 5510 running with an EVO 960.

@cristim

This comment has been minimized.

cristim commented May 21, 2017

I forked the project into a new Github organization, and it's available at https://github.com/sedutil/sedutil

Please join us there and re-submit this PR, we promise to merge it timely after passing the code review.

kylemanna and others added some commits May 8, 2017

docker: Add Docker build support
* Add Dockerfile to automagically build
* Add README to document how to execute
Dockerfile: Add gdisk which silently failed
* gdisk is necessary or the images won't work
autobuild.sh: Make invocation simpler
* Less work, fewer problems.
toolchain: Use the buildroot toolchain
Use the buildroot toolchain to compile LinuxPBA and sedutil-cli.
Without this, the build will use the host system's toolchain and
building on different distributions will cause breakage unless the
system libraries match the exact version that buildroot provides.
scripts: Fail when command return errors
Exit the script if any command returns a non-zero error code unless
explicitly handled.
buildpbaroot: Disable prompt
Disable the prompt for building build root.  This makes it difficult to
automate builds.
images: Update autobuild to use Buildroot toolchain
Re-order autobuild script to work with the buildroot toolchain.  This
results in the first Docker facilitiated build that works.

@verglor verglor referenced this pull request Jun 15, 2017

Merged

NVMe support in PBA #10

@kylemanna

This comment has been minimized.

kylemanna commented on LinuxPBA/UnlockSEDs.cpp in 5d99fae Jun 16, 2017

This is wrong, perhaps you meant:

+            case -1 : snprintf(devref,23,"/dev/sd%c",(char) 'a'+i);    break;

verglor and others added some commits Jun 20, 2017

Add line break
In a  previous commit, this was edited to break up lines. A mistake was made, neglecting the line break characters. Line 35 is not a switch statement, but a define statement. As such, the line needs to be broken up as a string. I tested this, but let me know if I made a mistake.
@cristim

This comment has been minimized.

cristim commented on d7ba90e Jul 14, 2017

Ouch, we missed this one, @laser-beans please create a PR for this.

This comment has been minimized.

Owner

laser-beans replied Jul 15, 2017

No need, this must have already been fixed. It looks like the master has the correct format.

@r0m30

This comment has been minimized.

Contributor

r0m30 commented Jul 20, 2017

Fixed in 1.15

@r0m30 r0m30 closed this Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment