Use nvme_ioctl.h for newer kernel versions #55 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header linux/nvme.h was replaced by linux/nvme_ioctl.h in kernel versions greater than 4.4: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9d99a8dda154 The needed structs and opcodes are copied into a new header file from nvme.h. See also: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a9cf8284b45110a4d98aea180a89c857e53bf850 https://www.bountysource.com/issues/29775575-linux-nvme-h-has-been-renamed-in-linux-4-4
|
What is the status of this PR? it seems pretty straight forward, and solves a show stopping bug on Linux-4.4+ |
|
I'm putting together a new release now and will include this fix. |
|
@r0m30: any progress on the new release? |
|
I forked the project into a new Github organization, and it's available at https://github.com/sedutil/sedutil Please join us there and re-submit this PR, we promise to merge it timely after passing the code review. |
|
Included in V1.15 |
metux
added a commit
to oss-qm/sedutil
that referenced
this pull request
Apr 19, 2019
The header linux/nvme.h was replaced by linux/nvme_ioctl.h in kernel versions greater than 4.4: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9d99a8dda154 The needed structs and opcodes are copied into a new header file from nvme.h. Author: Jan Luca Naumann <j.naumann@fu-berlin.de> Origin: Drive-Trust-Alliance#56 Bug: Drive-Trust-Alliance#52 Forwarded: Drive-Trust-Alliance#56 Applied-Upstream: Drive-Trust-Alliance#56 Last-Update: 2016-06-01
metux
added a commit
to oss-qm/sedutil
that referenced
this pull request
May 8, 2019
The header linux/nvme.h was replaced by linux/nvme_ioctl.h in kernel versions greater than 4.4: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9d99a8dda154 The needed structs and opcodes are copied into a new header file from nvme.h. Author: Jan Luca Naumann <j.naumann@fu-berlin.de> Origin: Drive-Trust-Alliance#56 Bug: Drive-Trust-Alliance#52 Forwarded: Drive-Trust-Alliance#56 Applied-Upstream: Drive-Trust-Alliance#56 Last-Update: 2016-06-01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header linux/nvme.h was replaced by linux/nvme_ioctl.h in kernel versions greater than 4.4: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9d99a8dda154
See also:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a9cf8284b45110a4d98aea180a89c857e53bf850
https://www.bountysource.com/issues/29775575-linux-nvme-h-has-been-renamed-in-linux-4-4