New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kapt #137

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
6 participants
@MoyuruAizawa
Contributor

MoyuruAizawa commented Feb 6, 2017

Overview (Required)

  • use kapt, kotlin codes can reference classes generated by DataBinding, Orma, KVS-Schema

why not use kotlin-kapt

kotlin-kapt is unstable yet.

@MoyuruAizawa MoyuruAizawa changed the title from Use kapt to [WIP]Use kapt Feb 6, 2017

app/licenses.yml
@@ -132,3 +132,11 @@
license: The Apache Software License, Version 2.0
licenseUrl: http://www.apache.org/licenses/LICENSE-2.0.txt
url: https://github.com/chrisjenx/Calligraphy
+- artifact: org.jetbrains.kotlin:kotlin-runtime:+

This comment has been minimized.

@gfx

gfx Feb 7, 2017

Member

Kotlin runtime libraries can be merged into a single section like this:

- artifact: org.jetbrains.kotlin:+:+
  name: Kotlin Runtime and Standard Library
  copyrightHolder: JetBrains Inc.
  license: The Apache Software License, Version 2.0 
@gfx

gfx Feb 7, 2017

Member

Kotlin runtime libraries can be merged into a single section like this:

- artifact: org.jetbrains.kotlin:+:+
  name: Kotlin Runtime and Standard Library
  copyrightHolder: JetBrains Inc.
  license: The Apache Software License, Version 2.0 

This comment has been minimized.

@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

thanks, merged these😀

@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

thanks, merged these😀

app/licenses.yml
+- artifact: org.jetbrains.kotlin:kotlin-stdlib:+
+ name: kotlin-stdlib
+ copyrightHolder: JetBrains Inc.
+ license: The Apache Software License, Version 2.0

This comment has been minimized.

@gfx

gfx Feb 7, 2017

Member

You should check the "Ensure line feed at file end on Save" in Android Studio 😎

screen shot 2017-02-07 at 9 17 44

@gfx

gfx Feb 7, 2017

Member

You should check the "Ensure line feed at file end on Save" in Android Studio 😎

screen shot 2017-02-07 at 9 17 44

This comment has been minimized.

@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

it mean, i have to ensure line feed at file end ?

@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

it mean, i have to ensure line feed at file end ?

@MoyuruAizawa MoyuruAizawa changed the title from [WIP]Use kapt to Use kapt Feb 7, 2017

app/build.gradle
- testCompile 'com.taroid.knit:knit:0.1.2'
- testCompile 'com.github.sys1yagi:kmockito:0.1.2'
+ testCompile('com.taroid.knit:knit:0.1.2') { exclude module:"kotlin-stdlib" }
+ testCompile('com.github.sys1yagi:kmockito:0.1.2') { exclude module:"kotlin-stdlib" }

This comment has been minimized.

@gfx

gfx Feb 7, 2017

Member

Use resolution strategy, just like as support-annotations defined above the dependencies.

@gfx

gfx Feb 7, 2017

Member

Use resolution strategy, just like as support-annotations defined above the dependencies.

force "com.android.support:support-annotations:${support_lib_version}"
}
}
}
+kapt {

This comment has been minimized.

@hotchemi

hotchemi Feb 7, 2017

Contributor

if i remember correctly this generate stub style is a bit old isn't it?
ref: https://blog.jetbrains.com/kotlin/2016/12/kotlin-1-0-6-is-here/

@hotchemi

hotchemi Feb 7, 2017

Contributor

if i remember correctly this generate stub style is a bit old isn't it?
ref: https://blog.jetbrains.com/kotlin/2016/12/kotlin-1-0-6-is-here/

This comment has been minimized.

@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

that's right, but i think kotlin-kapt plugin is unstable yet 😢

@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

that's right, but i think kotlin-kapt plugin is unstable yet 😢

This comment has been minimized.

@hotchemi

hotchemi Feb 7, 2017

Contributor

so you use this style for stability, gotcha.

@hotchemi

hotchemi Feb 7, 2017

Contributor

so you use this style for stability, gotcha.

@MoyuruAizawa

This comment has been minimized.

Show comment
Hide comment
@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

exceeded the memory limit 😢

Contributor

MoyuruAizawa commented Feb 7, 2017

exceeded the memory limit 😢

@gfx

This comment has been minimized.

Show comment
Hide comment
@gfx

gfx Feb 7, 2017

Member

OMG.

Splitting tasks like this https://github.com/gfx/Android-Orma/blob/master/circle.yml#L33-L38 might make CI stable.

Member

gfx commented Feb 7, 2017

OMG.

Splitting tasks like this https://github.com/gfx/Android-Orma/blob/master/circle.yml#L33-L38 might make CI stable.

@MoyuruAizawa

This comment has been minimized.

Show comment
Hide comment
@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

oh
there is a solution!?
thank you😲

Contributor

MoyuruAizawa commented Feb 7, 2017

oh
there is a solution!?
thank you😲

@MoyuruAizawa

This comment has been minimized.

Show comment
Hide comment
@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

like this?

test:
  override:
    - TERM=dumb ./gradlew clean assembleProductionDebug check jacocoTestReportDevelop
    - TERM=dumb find . -name app*debug.apk -exec mv {} $CIRCLE_ARTIFACTS/ \;
Contributor

MoyuruAizawa commented Feb 7, 2017

like this?

test:
  override:
    - TERM=dumb ./gradlew clean assembleProductionDebug check jacocoTestReportDevelop
    - TERM=dumb find . -name app*debug.apk -exec mv {} $CIRCLE_ARTIFACTS/ \;
@gfx

This comment has been minimized.

Show comment
Hide comment
@gfx

gfx Feb 7, 2017

Member

I'm afraid, like this:

test:
  override:
    - TERM=dumb ./gradlew assembleProductionDebug
    - TERM=dumb ./gradlew check
    - TERM=dumb ./gradlew jacocoTestReportDevelop
Member

gfx commented Feb 7, 2017

I'm afraid, like this:

test:
  override:
    - TERM=dumb ./gradlew assembleProductionDebug
    - TERM=dumb ./gradlew check
    - TERM=dumb ./gradlew jacocoTestReportDevelop

@konifar konifar added the in progress label Feb 7, 2017

@MoyuruAizawa

This comment has been minimized.

Show comment
Hide comment
@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

sorry😨
you mean

test:
  override:
    - TERM=dumb ./gradlew assembleProductionDebug
    - TERM=dumb ./gradlew check
    - TERM=dumb ./gradlew jacocoTestReportDevelop
    - find . -name app*debug.apk -exec mv {} $CIRCLE_ARTIFACTS/ \;

k?

Contributor

MoyuruAizawa commented Feb 7, 2017

sorry😨
you mean

test:
  override:
    - TERM=dumb ./gradlew assembleProductionDebug
    - TERM=dumb ./gradlew check
    - TERM=dumb ./gradlew jacocoTestReportDevelop
    - find . -name app*debug.apk -exec mv {} $CIRCLE_ARTIFACTS/ \;

k?

@gfx

This comment has been minimized.

Show comment
Hide comment
@gfx

gfx Feb 7, 2017

Member

Yep! 👍

Member

gfx commented Feb 7, 2017

Yep! 👍

@MoyuruAizawa

This comment has been minimized.

Show comment
Hide comment
@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

hmm...
a test using Robolectric failed

io.github.droidkaigi.confsched2017.ExampleUnitTest > addition_isCorrect FAILED
    org.apache.tools.ant.BuildException
        Caused by: org.apache.maven.artifact.resolver.MultipleArtifactsNotFoundException

looking for how to fix this, but i don't have no idea.
anyone has an idea??

Contributor

MoyuruAizawa commented Feb 7, 2017

hmm...
a test using Robolectric failed

io.github.droidkaigi.confsched2017.ExampleUnitTest > addition_isCorrect FAILED
    org.apache.tools.ant.BuildException
        Caused by: org.apache.maven.artifact.resolver.MultipleArtifactsNotFoundException

looking for how to fix this, but i don't have no idea.
anyone has an idea??

@jmatsu

This comment has been minimized.

Show comment
Hide comment
@jmatsu

jmatsu Feb 7, 2017

Member

@lvla
Maybe CircleCI's network issue...
For now, triggered rebuilding.

Member

jmatsu commented Feb 7, 2017

@lvla
Maybe CircleCI's network issue...
For now, triggered rebuilding.

+ - TERM=dumb ./gradlew assembleProductionDebug
+ - TERM=dumb ./gradlew check
+ - TERM=dumb ./gradlew jacocoTestReportDevelop
+ - find . -name app*debug.apk -exec mv {} $CIRCLE_ARTIFACTS/ \;

This comment has been minimized.

@jmatsu

jmatsu Feb 7, 2017

Member

@lvla
Can you revert this line's change? cp is correct command. 😄

@jmatsu

jmatsu Feb 7, 2017

Member

@lvla
Can you revert this line's change? cp is correct command. 😄

@konifar

This comment has been minimized.

Show comment
Hide comment
@konifar

konifar Feb 7, 2017

Collaborator

Thank you for your contribution! Sorry to be late comment 🙇
Actually, I'm a little negative to introduce kapt. Because kapt is not stable as you know.
After we introduce kapt, we might take time to solve its own problem.

Is there enough benefits to introduce it? I'm not sure, so I want to ask you

Collaborator

konifar commented Feb 7, 2017

Thank you for your contribution! Sorry to be late comment 🙇
Actually, I'm a little negative to introduce kapt. Because kapt is not stable as you know.
After we introduce kapt, we might take time to solve its own problem.

Is there enough benefits to introduce it? I'm not sure, so I want to ask you

@MoyuruAizawa

This comment has been minimized.

Show comment
Hide comment
@MoyuruAizawa

MoyuruAizawa Feb 7, 2017

Contributor

After we introduce kapt, we might take time to solve its own problem.
agree

i thought kapt is not suitable to develop with many people
close this PR :D

Contributor

MoyuruAizawa commented Feb 7, 2017

After we introduce kapt, we might take time to solve its own problem.
agree

i thought kapt is not suitable to develop with many people
close this PR :D

@MoyuruAizawa MoyuruAizawa deleted the MoyuruAizawa:use-kapt branch Feb 7, 2017

@KeithYokoma KeithYokoma removed the in progress label Feb 7, 2017

@konifar

This comment has been minimized.

Show comment
Hide comment
@konifar

konifar Feb 7, 2017

Collaborator

Sorry 🙇
Anyway, thank you for contribution!!

Collaborator

konifar commented Feb 7, 2017

Sorry 🙇
Anyway, thank you for contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment