New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce Debot #219

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
2 participants
@noboru-i
Contributor

noboru-i commented Jan 16, 2018

Issue

Overview (Required)

Links

Screenshot

@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

👀

@noboru-i

This comment has been minimized.

Contributor

noboru-i commented Jan 16, 2018

Oh, I fix bot's comment.

@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

Looks good 👍
If it is possible, I don't want to add to BaseActivity.
If you have time, Please try Application.ActivityLifecycleCallbacks or Android Architecture Components lifecycles.

@noboru-i

This comment has been minimized.

Contributor

noboru-i commented Jan 16, 2018

Thanks! I understand.
I will try to use Android Architecture Components lifecycles.

@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

@noboru-i Is danger-checkstyle_format your plugin? It's funny 😄

@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

Probably we can do it with ProcessLifecycleOwner 👍

@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

LGTM👍Thank you for your contribution!

@noboru-i

This comment has been minimized.

Contributor

noboru-i commented Jan 16, 2018

@takahirom
I try to use ProcessLifecycleOwner, but sorry, I cannot do that.
So I use ActivityLifecycleCallbacks.

Detail:
When calling startSensor, we need to Activity instance.
But I cannot find way to get Activity instance...

If you feel ok, I will squash commits.

@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

Thank you for investigating! ActivityLifecycleCallbacks should be used.👍

@noboru-i

This comment has been minimized.

Contributor

noboru-i commented Jan 16, 2018

@takahirom
Thank you for reviewing. 🙇
I squashed commits.
If you feel ok, please merge this. Thanks 👍

@takahirom takahirom merged commit 97de15f into DroidKaigi:master Jan 16, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
danger/danger ⚠️ 9 Warnings. Don't worry, everything is fixable.
@takahirom

This comment has been minimized.

Member

takahirom commented Jan 16, 2018

Thanks!👍

@noboru-i noboru-i deleted the noboru-i:add-debug-menu branch Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment