Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last item divider on About screen #464

Merged
merged 2 commits into from Jan 14, 2019
Merged

Remove last item divider on About screen #464

merged 2 commits into from Jan 14, 2019

Conversation

dnc-pop30
Copy link
Contributor

Issue

Overview (Required)

  • Remove last item divider on About screen

Links

Screenshot

Before After

KeithYokoma
KeithYokoma approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@KeithYokoma KeithYokoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The code looks good to me! Let's wait for the CI...

@jmatsu-bot
Copy link
Collaborator

Your app is deployed! Try it via https://deploygate.com/distributions/e2448111351a39d2f2ebe7a1cf9b7bca54bf0cb9

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 13827257 Bytes. (13.19 MB)
File Size Change +41436 Bytes. (+40.46 KB)
Download Size Change +41972 Bytes. (+40.99 KB)
New Method Reference Count 153933
Method Reference Count Change 199
New Number of dex file(s) 4
Number of dex file(s) Change 0

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

@KeithYokoma
Copy link
Contributor

OK CI also approved so I will merge this. Thank you again!

@KeithYokoma KeithYokoma merged commit ad9e94c into DroidKaigi:master Jan 14, 2019
@dnc-pop30
Copy link
Contributor Author

Thank you😁!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeithYokoma KeithYokoma KeithYokoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove last item divider on About screen
3 participants
@dnc-pop30 @jmatsu-bot @KeithYokoma