Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand animation is incorrect when tap "Read more" button in session detail #751

Closed
koji-1009 opened this issue Feb 9, 2020 · 1 comment
Closed

Comments

@koji-1009
Copy link
Contributor

@koji-1009 koji-1009 commented Feb 9, 2020

Overview (Required)

  • Tap "Read more" button, the speaker cell is overlapped the description cell.
  • Then, scroll down speaker cell and show the description cell.

Steps To Reproduce

  1. Go to SessionDetail
  2. Click on "Read more" button
  3. See animation

Expected behavior

Cells do not overlap.

Screenshots

Env:

  • Device: Pixel 2(emulator)
  • OS: 10
  • master

Additional context

Maybe this is a degraded problem.
See DeployGate at #592 and #682 .

@keeepon

This comment has been minimized.

Copy link
Contributor

@keeepon keeepon commented Feb 10, 2020

This issue can be avoided by running "adapter.clear()" before "adapter.update(items)" in the setupSessionViews method of the SessionDetailFragment class, but I'm not sure this implementation is correct.

When "adapter.clear()" is run, "notifyItemRangeInserted()" works.
When "adapter.clear()" is not run, "notifyItemRangeChanged()" works.

// Example: SessionDetailFragment class line 247

adapter.clear()
adapter.update(items)
startPostponedEnterTransition()

01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.