Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Dagger injection & Use Fragment LayoutId constructor #618

Merged
merged 8 commits into from Jan 26, 2020

Conversation

@nashcft
Copy link
Contributor

nashcft commented Jan 26, 2020

Issue

Overview (Required)

  • Add AppInjector and replace DaggerAppCompatActivity and DaggerFragment to it for auto-injection
  • Use Fragment LayoutId constructor instead of onCreateView because We can now use androidx.fragment.app.Fragment as the super class for our Fragments

Links

Screenshot

No UI change

}
}


This comment has been minimized.

Copy link
@jmatsu-bot

jmatsu-bot Jan 26, 2020

Collaborator
🚫 Needless blank line(s)
@jmatsu-bot

This comment has been minimized.

Copy link
Collaborator

jmatsu-bot commented Jan 26, 2020

No issue was reported. Cool!

Generated by 🚫 Danger

@jmatsu-bot

This comment has been minimized.

Copy link
Collaborator

jmatsu-bot commented Jan 26, 2020

Your apk has been deployed to https://deploygate.com/distributions/daaf85ad9dbe0044ace2e08b40d10822287d3ded. Anyone can try your changes via the link.

Generated by 🚫 Danger

@takahirom takahirom added the awesome label Jan 26, 2020
@takahirom

This comment has been minimized.

Copy link
Member

takahirom commented Jan 26, 2020

Looks awesome 🙏

@takahirom takahirom merged commit a5d06df into DroidKaigi:master Jan 26, 2020
3 checks passed
3 checks passed
ci/circleci: assemble_apk Your tests passed on CircleCI!
Details
ci/circleci: test_android Your tests passed on CircleCI!
Details
every_pull_request Workflow: every_pull_request
Details
@nashcft nashcft deleted the nashcft:dagger_auto_injection branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.