Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style Theme.DroidKaigi.ActionBar for dark theme #732

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@nashcft
Copy link
Contributor

nashcft commented Feb 6, 2020

Issue

  • N/A

Overview (Required)

  • Add a style Theme.DroidKaigi.ActionBar to adapt license page to dark theme

Links

Screenshot

Before After

tested device: Pixel 3
OS version: 10

@jmatsu-bot

This comment has been minimized.

Copy link
Collaborator

jmatsu-bot commented Feb 6, 2020

Your apk has been deployed to https://deploygate.com/distributions/c79f3489ac20c4286aa1622cbc28144875429509. Anyone can try your changes via the link.

Generated by 🚫 Danger

@jmatsu-bot

This comment has been minimized.

Copy link
Collaborator

jmatsu-bot commented Feb 6, 2020

No issue was reported. Cool!

Generated by 🚫 Danger

@takahirom

This comment has been minimized.

Copy link
Member

takahirom commented Feb 6, 2020

I don't notice it😆

@takahirom takahirom merged commit b4964a1 into DroidKaigi:master Feb 6, 2020
3 checks passed
3 checks passed
ci/circleci: assemble_apk Your tests passed on CircleCI!
Details
ci/circleci: test_android Your tests passed on CircleCI!
Details
every_pull_request Workflow: every_pull_request
Details
@nashcft nashcft deleted the nashcft:dark_theme_license_page branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.