Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequence datatype inputs fix for random.sample calls #20

Merged
merged 2 commits into from
Apr 20, 2023
Merged

sequence datatype inputs fix for random.sample calls #20

merged 2 commits into from
Apr 20, 2023

Conversation

aebrer
Copy link
Contributor

@aebrer aebrer commented Apr 18, 2023

should fix #19

@aebrer aebrer mentioned this pull request Apr 18, 2023
Closed
@DrrDom
Copy link
Owner

DrrDom commented Apr 19, 2023

Thank you for the contribution!
It seems that the explicit conversion of a list to a set in row_ids.difference_update(set(selected_row_ids)) is not necessary. If so, could you revert this change back? After that I'll accept a pull request.

@aebrer
Copy link
Contributor Author

aebrer commented Apr 19, 2023

Got it! reverted the change! :)

@DrrDom
Copy link
Owner

DrrDom commented Apr 20, 2023

Thank you! I'll accept it right now

@DrrDom DrrDom merged commit 01215ea into DrrDom:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] package is incompatible with python 3.11+
2 participants
@aebrer @DrrDom