Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M500 return code, update DWC branch #68

Closed
wants to merge 4 commits into from

Conversation

gtjoseph
Copy link
Contributor

No description provided.

Even though M500 is currently not working because the model is empty,
the file does get written so we should return MessageType.Success
instead of falling through to OperationCancelled.
@wilriker
Copy link
Contributor

(You wanted to remove arm and armv6h from the packaging with your next change) ;-D

@gtjoseph
Copy link
Contributor Author

HA! I completely forgot. In progress.

Rather than thowing an exception (which can prevent a successful
start of RRF), we now catch IOExceptions and return Error with
an error message.
@chrishamm
Copy link
Contributor

Thanks for the build script improvements and for pointing out the problems with the heightmap codes + M500. I've merged your build script improvement manually and decided to catch all exceptions instead of only AggregateExceptions. In RRF, M500 does not return any message on success so I think it's better if DCS does the same.

@chrishamm chrishamm closed this Oct 21, 2019
@gtjoseph gtjoseph deleted the dev-for-chrishamm branch December 14, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants