Adds line force readouts for Hangprinter ODrive #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... And also changes units when setting torque mode, from Nm to N. These readouts can be useful for detecting slack lines or over tight lines during print or calibration. They can also enable automatic homing, since homing a Hangprinter includes setting the correct pre-tension. The change of units when setting torque mode is to be consistent across interfaces. Newtons of force are also much easier to understand and harder to mis-type. New usable torque mode values are in the range ~10, instead of around ~0.05 like we had before, which invited the typos "0.5" and "5.0", who could both create dangerous situations.
Contributor
Author
|
I wrote on the reprap gcode wiki page: https://reprap.org/wiki/G-code#M569.8:_Read_Axis_Force |
tobbelobb
added a commit
to tobbelobb/hangprinter
that referenced
this pull request
Mar 24, 2022
... which is an up and coming feature. See Duet3D/RepRapFirmware#564
Collaborator
|
Your new code in GCodes3.cpp function ConfigureLocalDriver doesn't appear to me to cover subfunction 8 yet. (EDIT: or subfunction 4). |
Contributor
Author
|
Yes, you're right. Will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... And also changes units when setting torque mode, from Nm to N.
These readouts can be useful for detecting slack lines or over
tight lines during print or calibration.
They can also enable automatic homing, since homing a Hangprinter
includes setting the correct pre-tension.
The change of units when setting torque mode is to be consistent
across interfaces. Newtons of force are also much easier to
understand and harder to mis-type.
New usable torque mode values are in the range ~10,
instead of around ~0.05 like we had before, which invited the
typos "0.5" and "5.0", who could both create dangerous situations.