Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no activity.isDestroyed() in android jellybean 16 #552

Open
wants to merge 2 commits into
base: master
from

Conversation

@HarishJangra
Copy link

HarishJangra commented Sep 3, 2019

fixes a crash in android 4.1(api 16)

fixes a crash in android 4.1(api 16)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           1        1           
  Lines          17       17           
=======================================
  Hits           16       16           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94e6fe...f81aefe. Read the comment docs.

@vieiralucas

This comment has been minimized.

Copy link
Contributor

vieiralucas commented Oct 22, 2019

I'm facing the same problem. @DylanVann can you take a look at this PR please?
It looks good to me

rebase with origin
@fonov

This comment has been minimized.

Copy link

fonov commented Nov 11, 2019

some problem #595 this fix need merge asap

@MiloszFilimowski

This comment has been minimized.

Copy link

MiloszFilimowski commented Dec 18, 2019

Any plans to merge this? I can confirm that this fix resolves the issue.

@HessiPard

This comment has been minimized.

Copy link

HessiPard commented Dec 28, 2019

Any news for merging this?

@el173
el173 approved these changes Feb 17, 2020
@el173
el173 approved these changes Feb 17, 2020
Copy link

el173 left a comment

This works fine in production; I'm using this fix on an app which has over 4 million users.

@appli-intramuros

This comment has been minimized.

Copy link

appli-intramuros commented Feb 18, 2020

Can you merge this @DylanVann ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.