DYN-10101 : dynamo opens wrong samples directory when opening containing folder for a different locale

[ivaylo-matov]

Purpose

This PR addresses DYN-10101, where the open containing folder action on sample files always opened the en-US samples directory, regardless of the user's locale preference setting in Dynamo.

The issue was an initialization order problem:
PathManager was constructed and samplesDirectory was set using CultureInfo.CurrentUICulture. At this point preferences are not loaded yet, so CurrentUICulture was always the system default.

Proposed resolution:

• removed initialization of samplesDirectory in PathManager.BuildCommonDirectories
• converted SamplesDirectory to a lazy-loading property that calculates the path on first access
• at first access, preferences are already loaded, so the correct locale is used
• added logic to handle the "Default" locale setting by falling back to en-US
• refactored GetSamplesFolder to accept a locale argument
• added unit test

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

Fixes a bug where the open containing folder action on sample files always opened the en-US samples directory, regardless of the user's locale preference setting in Dynamo.

Reviewers

@zeusongit
@DynamoDS/eidos

FYIs

@dnenov
@achintyabhat

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10101

[Copilot]

Pull request overview

This PR fixes DYN-10101 where opening the containing folder for sample files always opened the en-US directory instead of respecting the user's locale preference. The root cause was an initialization order issue where PathManager set the samples directory before preferences were loaded, causing it to use the system default culture instead of the user's configured locale.

Changes:

• Converted SamplesDirectory to a lazy-loading property that evaluates on first access (when preferences are loaded)
• Refactored GetSamplesFolder to accept a locale parameter instead of using CultureInfo.CurrentUICulture directly
• Added test coverage to verify samples directory respects locale preferences

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/DynamoCore/Configuration/PathManager.cs	Implemented lazy-loading for SamplesDirectory property, refactored GetSamplesFolder to accept locale parameter, and fixed typo "netural" to "neutral"
test/DynamoCoreTests/Configuration/PreferenceSettingsTests.cs	Added unit test to verify SamplesDirectory respects locale preferences