DYN-10076: Home and End keys work while working in the Publishing a Package page#16886
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10076
There was a problem hiding this comment.
Pull request overview
This PR fixes Package Manager keyboard handling during package publishing so common text-editing keys (Home/End) aren’t intercepted for tab navigation, while keeping PageUp/PageDown tab navigation when the tab strip is focused.
Changes:
- Introduced
PackageManagerTabControlto centralize keyboard handling and focus behavior. - Updated Package Manager XAML to use the new control and renamed the tab control field for clarity.
- Added an attachable property to selectively suppress Home/End tab switching on the Publish tab.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs | Renames the referenced tab control to match the new XAML name. |
| src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml | Swaps in PackageManagerTabControl and applies suppression behavior to the Publish tab. |
| src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerTabControl.cs | Adds the custom TabControl implementing key handling + focus behavior. |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Declares the new public control and members for API tracking. |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Includes the new control file in compilation. |
|
|
PressNotificationButtonAndShowPopup passes locally |
jasonstratton
left a comment
jasonstratton
left a comment
There was a problem hiding this comment.
Looks good, but the Dynamo SelfServe and Dynamo Smoke Tests are failing.
Purpose
This PR addresses DYN-10076 by preventing Package Manager tab navigation keys from stealing common text-editing shortcuts while publishing a package. The proposal centralizes tab key behavior in a dedicated control.
Changes:
PackageManagerTabControlto own tab keyboard behavior.PageUp/PageDowntab navigation only when the tab strip has focus.PackageManagerTabControl.SuppressHomeEndWhenSelected- applied topublishTabin xaml, soHome/Endtab switching is suppressed only in that scenario.Home/Endis intentionally left unhandled so hosted content can process these keys.PackageManagerTabControl(Loaded+OnSelectionChanged).projectManagerTabControltopackageManagerTabControlfor clarity.Declarations
Check these if you believe they are true
Release Notes
Improved Package Manager keyboard behavior so publish-form shortcuts (Home/End variants) work correctly in the Publish tab while still supporting PageUp/PageDown tab navigation from tab headers.
Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov