Skip to content

DYN-10112: Notes should not overlay warning/error/info bubbles over nodes#16893

Merged
jasonstratton merged 3 commits into
DynamoDS:masterfrom
zeusongit:10112
Feb 18, 2026
Merged

DYN-10112: Notes should not overlay warning/error/info bubbles over nodes#16893
jasonstratton merged 3 commits into
DynamoDS:masterfrom
zeusongit:10112

Conversation

@zeusongit
Copy link
Copy Markdown
Contributor

@zeusongit zeusongit commented Feb 12, 2026

Purpose

Simplified approach:
Boosted z-index on mouse enter to max value and restore on mouse leave

Declarations

Check these if you believe they are true

Release Notes

  • Info bubbles render above nodes and notes reliably when visible.

Introduce Configurations.InfoBubbleBaseZIndex (1,000,000) and use it as the default ZIndex for info/error/warning bubbles. Decouple bubble ZIndex from node ZIndex by removing node-driven updates in NodeViewModel and assigning the base ZIndex when building the bubble. Update InfoBubbleView to elevate the ViewModel.ZIndex to int.MaxValue - 1 when showing/fading in the bubble and restore it to the base when hiding/fading out. This ensures bubbles render above nodes and notes reliably when visible.
@zeusongit zeusongit requested review from a team and Copilot February 12, 2026 23:44
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10112

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts InfoBubble Z-indexing in Dynamo’s WPF UI to prevent info/warning/error bubbles from being visually obscured by nodes and notes, improving reliability of message visibility.

Changes:

  • Introduces Configurations.InfoBubbleBaseZIndex as a default/idle ZIndex for info bubbles.
  • Decouples bubble ZIndex from node ZIndex updates by removing node-driven bubble ZIndex adjustments.
  • Updates InfoBubbleView to boost ZIndex on show/fade-in and restore on hide/fade-out.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/DynamoCoreWpf/Views/Preview/InfoBubbleView.xaml.cs Boost/restore bubble ZIndex during show/hide and fade transitions.
src/DynamoCoreWpf/ViewModels/Core/NodeViewModel.cs Removes node-driven bubble ZIndex updates; initializes bubble ZIndex from a base configuration value.
src/DynamoCore/Configuration/Configurations.cs Adds a base ZIndex constant intended to keep bubbles above nodes/notes.

Comment thread src/DynamoCoreWpf/Views/Preview/InfoBubbleView.xaml.cs
Comment thread src/DynamoCoreWpf/Views/Preview/InfoBubbleView.xaml.cs
Comment thread src/DynamoCore/Configuration/Configurations.cs Outdated
Comment thread src/DynamoCoreWpf/ViewModels/Core/NodeViewModel.cs Outdated
Store the bubble's previous ZIndex and temporarily boost it when the info bubble is hovered to ensure expanded content isn't blocked by other elements. Adds a previousZIndex field, sets ViewModel.ZIndex to int.MaxValue-1 on MouseEnter, and restores the original value on MouseLeave.
@sonarqubecloud
Copy link
Copy Markdown

@jasonstratton jasonstratton merged commit 2ab32a3 into DynamoDS:master Feb 18, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants