Skip to content

[Cherry-pick] DYN-10167: Crash fix. Prevent close on Alt+F4 and hide instead.#17016

Merged
zeusongit merged 1 commit into
RC4.1.0_masterfrom
cherrypick-16998
Apr 3, 2026
Merged

[Cherry-pick] DYN-10167: Crash fix. Prevent close on Alt+F4 and hide instead.#17016
zeusongit merged 1 commit into
RC4.1.0_masterfrom
cherrypick-16998

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Apr 3, 2026

Cherry-pick of #16998 to RC4.1.0_master

Purpose

Several crash reports indicate that Dynamo may crash when trying to Show the node autocomplete window. This happened because we did not consider that the user could close the autocomplete window by focusing it and pressing Alt+F4. since there is no UI to really close the window (we hide it for later reuse instead).

Reproduction steps of the crash fixed by this ticket:

  • Create a node
  • Click the autocomplete sparkle
  • By focusing the autocomplete popup (say, by clicking on it) and pressing Alt+F4, we forcefully close the window, and leave dangling transient nodes.
  • We then try to open the autocomplete window from the port again. This will result in a crash.

This PR fixes both bugs.

Declarations

Check these if you believe they are true

Release Notes

Fix crash when closing node autocomplete window with Alt+F4.

Reviewers

@johnpierson
@BogdanZavu

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

@zeusongit zeusongit merged commit e9974be into RC4.1.0_master Apr 3, 2026
13 of 14 checks passed
@zeusongit zeusongit deleted the cherrypick-16998 branch April 3, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants