New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python template support 2.0 #8122
Commits on Aug 17, 2017
-
added code regions and fixed annotations
- introduced code regions - moved class properties to appropriate regions - fixed a few summary annotations to make it clearer what they do/return and adhere to Microsoft standards a bit better
-
added PythonTemplateFile setting
- added public property to class for PythonTemplateFilePath - added default value in the Settings constructor
-
added PythonTemplateFilePath to interfaces
Implemented support for the file path, following the model of the PreferencesFilePath.
-
read template for Python nodes + documentation
- when adding a Python node, the template is read - added conditional load & fallback on hardcoded text if template is not found - replaced "\n" with `Environment.NewLine` in hardcoded template - added new comment lines to default template, using Resources to make it easier for beginners - fixed typo in existing Resources & XAML
-
default Python template cleanup
- added an extra spacing line - added spaces after `#` Python comment marker
-
add static backing store for PythonTemplateFIlePath
The backing store is required as a static property cannot implement an interface member.
Commits on Aug 18, 2017
-
-
add public static method to access private static prop
The backing store is private & static, so it doesn't get serialised when settings are saved. Hence, we add a public static method to access it.
-
Commits on Aug 21, 2017
-
replaced template get with static method call
gets rid of un-necessary initialisation of new `PreferenceSettings` or `PathManager` classes, see DynamoDS#8034 (review)
-
changed PathManager python template prop to static
actually gets rid of un-necessary initialisation of new `PreferenceSettings` or `PathManager` classes, see DynamoDS#8034 (review) forgot the PathManager in last commit.
Commits on Aug 22, 2017
-
removed duplicate file tracking for `AssemblySharedInfo.cs` https://github.com/DynamoDS/Dynamo/blob/8e8fe12f89150be1fe7f24edf9931859b59c731a/.gitignore#L74
Commits on Aug 24, 2017
Commits on Aug 25, 2017
-
removed static PathManager props & added PyTemplate handling to Dynam…
…oModel - removed static getter in PathManager and changed backing prop to instance - added handling of user Python file, default file or no template - added logging - added log messages to `*.resx` DynamoDS#8122 (review)
-
Commits on Aug 27, 2017
-
added settings files for tests
- added XML settings files for tests - renamed existing settings file to fit in better with structure (easier to group & read by humans) - consolidated files for previous test `oadInvalidPythonTemplateFromSetting` in `Settings.cs`
-
added unit test for CanUpdatePythonTemplateSettings
- test passes locally - test requires 2 new python files, included them in same folder - test generates 1 additional settings file when run, `DynamoSettings-PythonTemplate-changed.XML` - test does not depend on hard-coded paths
-
re-enable the temporarily disabled tests
these 2 tests were taking 10 minutes to run, had to disable them whilst building the new Python tests.
-
-
ensure order of execution is right
checking files required by test exist should be done before those files are read
-