Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python template support 2.0 #8122

Merged
merged 23 commits into from Aug 28, 2017
Merged

Commits on Aug 17, 2017

  1. added code regions and fixed annotations

    - introduced code regions
    - moved class properties to appropriate regions
    - fixed a few summary annotations to make it clearer what they do/return and adhere to Microsoft standards a bit better
    radumg committed Aug 17, 2017
    Copy the full SHA
    d99134f View commit details
    Browse the repository at this point in the history
  2. added PythonTemplateFile setting

    - added public property to class for PythonTemplateFilePath
    - added default value in the Settings constructor
    radumg committed Aug 17, 2017
    Copy the full SHA
    7eb91cc View commit details
    Browse the repository at this point in the history
  3. added PythonTemplateFilePath to interfaces

    Implemented support for the file path, following the model of the PreferencesFilePath.
    radumg committed Aug 17, 2017
    Copy the full SHA
    8e9c755 View commit details
    Browse the repository at this point in the history
  4. read template for Python nodes + documentation

    - when adding a Python node, the template is read
    - added conditional load & fallback on hardcoded text if template is not found
    - replaced "\n" with `Environment.NewLine` in hardcoded template
    - added new comment lines to default template, using Resources to make it easier for beginners
    - fixed typo in existing Resources & XAML
    radumg committed Aug 17, 2017
    Copy the full SHA
    2d9f4e0 View commit details
    Browse the repository at this point in the history
  5. default Python template cleanup

    - added an extra spacing line
    - added spaces after `#` Python comment marker
    radumg committed Aug 17, 2017
    Copy the full SHA
    a12d5df View commit details
    Browse the repository at this point in the history
  6. add static backing store for PythonTemplateFIlePath

    The backing store is required as a static property cannot implement an interface member.
    radumg committed Aug 17, 2017
    Copy the full SHA
    c13ef1c View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2017

  1. Copy the full SHA
    ad36dae View commit details
    Browse the repository at this point in the history
  2. add public static method to access private static prop

    The backing store is private & static, so it doesn't get serialised when settings are saved. Hence, we add a public static method to access it.
    radumg committed Aug 18, 2017
    Copy the full SHA
    bd658e4 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    773a416 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2017

  1. replaced template get with static method call

    gets rid of un-necessary initialisation of new `PreferenceSettings` or `PathManager` classes, see DynamoDS#8034 (review)
    radumg committed Aug 21, 2017
    Copy the full SHA
    2f234bb View commit details
    Browse the repository at this point in the history
  2. changed PathManager python template prop to static

    actually gets rid of un-necessary initialisation of new `PreferenceSettings` or `PathManager` classes, see DynamoDS#8034 (review)
    forgot the PathManager in last commit.
    radumg committed Aug 21, 2017
    Copy the full SHA
    9308735 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2017

  1. Update .gitignore

    radumg committed Aug 22, 2017
    Copy the full SHA
    d221139 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2017

  1. remove unnecessary reference

    radumg committed Aug 24, 2017
    Copy the full SHA
    5be6f8b View commit details
    Browse the repository at this point in the history
  2. Merge branch 'python-template' of https://github.com/radumg/Dynamo in…

    …to python-template
    radumg committed Aug 24, 2017
    Copy the full SHA
    6227c43 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2319431 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2017

  1. removed static PathManager props & added PyTemplate handling to Dynam…

    …oModel
    
    - removed static getter in PathManager and changed backing prop to instance
    - added handling of user Python file, default file or no template
    - added logging
    - added log messages to `*.resx`
    DynamoDS#8122 (review)
    radumg committed Aug 25, 2017
    Copy the full SHA
    c4bff15 View commit details
    Browse the repository at this point in the history
  2. added PythonTemplate file test

    radumg committed Aug 25, 2017
    Copy the full SHA
    a99bde1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2017

  1. added settings files for tests

    - added XML settings files for tests
    - renamed existing settings file to fit in better with structure (easier to group & read by humans)
    - consolidated files for previous test `oadInvalidPythonTemplateFromSetting` in `Settings.cs`
    radumg committed Aug 27, 2017
    Copy the full SHA
    9ff3479 View commit details
    Browse the repository at this point in the history
  2. added unit test for CanUpdatePythonTemplateSettings

    - test passes locally
    - test requires 2 new python files, included them in same folder
    - test generates 1 additional settings file when run, `DynamoSettings-PythonTemplate-changed.XML`
    - test does not depend on hard-coded paths
    radumg committed Aug 27, 2017
    Copy the full SHA
    bdb6c23 View commit details
    Browse the repository at this point in the history
  3. re-enable the temporarily disabled tests

    these 2 tests were taking 10 minutes to run, had to disable them whilst building the new Python tests.
    radumg committed Aug 27, 2017
    Copy the full SHA
    5a73bf0 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    239fd8c View commit details
    Browse the repository at this point in the history
  5. ensure order of execution is right

    checking files required by test exist should be done before those files are read
    radumg committed Aug 27, 2017
    Copy the full SHA
    083fce5 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    0ba2bc8 View commit details
    Browse the repository at this point in the history