Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GeometryColor resource file for localization #9435

Merged
merged 1 commit into from Feb 28, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 16, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

REVIT-142521
GLOB: Untranslated strings in Library - Geometry node - Modifiers - Geometry Color - Hardcoded strings

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@andydandy74

FYIs

@ZiyunShang

@QilongTang QilongTang added the WIP label Jan 16, 2019
@QilongTang
Copy link
Contributor Author

QilongTang commented Feb 28, 2019

@andydandy74 @ZiyunShang As a follow up of the task, I may need your help to update https://git.autodesk.com/revit/revit/blob/7fc47aec0418b932100a3fab2cd6d1392c32943d/Source/Install/Revit/msm/RevitMSM/wxs/opt/optRevitAddInsDynamoForRevitGlob.wxs#L212 when you consume Dynamo 2.2.0

@QilongTang QilongTang changed the title [WIP] Move GeometryColor resource file Move GeometryColor resource file for localization Feb 28, 2019
@QilongTang QilongTang added LGTM Looks good to me and removed WIP labels Feb 28, 2019
@QilongTang QilongTang merged commit 01e036a into master Feb 28, 2019
@QilongTang QilongTang deleted the GeometryColorLocalization branch February 28, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants