New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#1360: add handling for NtSetTimer2 #2072

Merged
merged 3 commits into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@shawndenbow
Contributor

shawndenbow commented Jan 18, 2018

No description provided.

@derekbruening

Thank you for the patch, I just have one suggestion.

Show outdated Hide outdated drsyscall/drsyscall.h
@derekbruening

This comment has been minimized.

Show comment
Hide comment
@derekbruening

derekbruening Jan 19, 2018

Contributor

Some nits regarding the commit message: when you do the squash-and-merge, please add at least one line for the commit message body (even if it basically repeats what's in the title), and add a line like Issue: #1360 to get an auto-link. Plus we typically put a little description after the i# in the title for multi-commit issues, so sthg like i#1360 win8.1 syscalls: add handling for NtSetTimer2.

Contributor

derekbruening commented Jan 19, 2018

Some nits regarding the commit message: when you do the squash-and-merge, please add at least one line for the commit message body (even if it basically repeats what's in the title), and add a line like Issue: #1360 to get an auto-link. Plus we typically put a little description after the i# in the title for multi-commit issues, so sthg like i#1360 win8.1 syscalls: add handling for NtSetTimer2.

@shawndenbow

This comment has been minimized.

Show comment
Hide comment
@shawndenbow

shawndenbow Jan 20, 2018

Contributor

Travis failure is Mac #2038

Contributor

shawndenbow commented Jan 20, 2018

Travis failure is Mac #2038

@derekbruening derekbruening merged commit 2f12324 into master Jan 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@derekbruening derekbruening deleted the i1360-fix-ntsettimer2 branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment