Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan with index #503

Merged
merged 3 commits into from May 8, 2021
Merged

Conversation

bmalinconico
Copy link
Contributor

@bmalinconico bmalinconico commented Apr 30, 2021

I found a bug when forcing and index and not filtering by hash key. This fixes that and pushes the logic down into the adapter.

I'll be back to this on monday, please let me know if you would like to try and satisfy code climate's complexity concerns.

@andrykonchin
Copy link
Member

Looks pretty good 👍 . Thank you.

@andrykonchin andrykonchin merged commit 1316e16 into Dynamoid:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants