-
Notifications
You must be signed in to change notification settings - Fork 46
feat: updated react and react-hooks sample and docs #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
349a0a1 to
a10a580
Compare
Keillion
reviewed
Jun 26, 2024
| npm install dynamsoft-barcode-reader | ||
| npm install dynamsoft-capture-vision-router | ||
| npm install dynamsoft-camera-enhancer | ||
| npm install dynamsoft-barcode-reader-bundle |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install dynamsoft-barcode-reader-bundle@10.2.1000 -E
Keillion
approved these changes
Jun 26, 2024
Justin-dynamsoft
pushed a commit
that referenced
this pull request
Nov 24, 2025
* feat: updated react sample to follow readme * fix: match results class to style guide * feat: add link canonical * fix: Changed Video capture to decode video, and image too * fix: Added comments on dynamsoft.config.ts * fix formatter printWidth to 120 * fix: handle uncaught runtime errors * fix: standarize HelloWorld component on App.tsx * finalized react update * fix: update both react and react-hooks * fix: typo * moved comment * update readme to add customization for ui --------- Co-authored-by: felixindrawan <indrawan.felix123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
React README wasn't accurate, and also didn't have a guide to setup and launch the sample we currently have.
In the README, the sample code is not the same as what we have in the sample.
We also haven't formatted the code.
Solution
Big changes to note:
GENERAL
README.md
dynamsoft-barcode-reader-bundlecvrtodynamsoft.config.tsVideoCapture.tsx / ImageCapture.tsx
EnumapturedResultItemTypeimportuiContainertocameraViewContainerresultsContainer.current!.textContent +=${item.formatString}: ${item.text}\n\n;filter.setDuplicateForgetTimeThe component should never updateforreact-hook