Skip to content
This repository has been archived by the owner. It is now read-only.

Decide on how to deal with mistake in manual regarding updated variables #1366

Closed
JohannesPfeifer opened this issue Jan 1, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@JohannesPfeifer
Copy link
Contributor

commented Jan 1, 2017

According to the manual, smoother triggers the computation of oo_.UpdatedVariables. But one actually needs filtered_vars. We can either

  1. Correct the description in the manual to reflect the code behavior
  2. Flag this as a bug as the code deviates from the manual and output oo_.UpdatedVariables when only the smoother option is specified
@JohannesPfeifer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2017

@MichelJuillard I would like to fix this soon. Which option do you prefer?

@MichelJuillard

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

@JohannesPfeifer I don't understand the issue. What is computed by smoother? What is in the manual? I don' t have time to check it now, sorry. If the computations are satisfactory, I would correct the manual

JohannesPfeifer added a commit to JohannesPfeifer/dynare that referenced this issue Jan 4, 2017

@JohannesPfeifer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2017

@MichelJuillard We compute the required objects in the smoother routine, but did not save the results in oo_ due to a check for filtered_vars. In #1370 I make the saving consistent with the manual.

@MichelJuillard

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

@JohannesPfeifer perfect! Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.