Skip to content
This repository has been archived by the owner. It is now read-only.

Bugfixes and cosmetic changes related to estimation #1297

Merged
merged 5 commits into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@JohannesPfeifer
Copy link
Contributor

commented Oct 3, 2016

  • Solves Octave unit test fails related to mh_recover by conditioning the seed resetting on the presence of Octave
  • Fixes bug in GetPosteriorMeanVariance.mwhen number of dropped draws coinided with number of draws in the mh_file; in this case the results were NaN
if ~isoctave
set_dynare_seed(options_.DynareRandomStreams.algo, options_.DynareRandomStreams.seed);
% Set the state of the RNG
set_dynare_random_generator_state(record.InitialSeeds(curr_block).Unifor, record.InitialSeeds(curr_block).Normal);

This comment has been minimized.

Copy link
@houtanb

houtanb Oct 4, 2016

Member

It seems like line 132 is the same as 136. Can you move 131-132 outside of the if statement and delete 135-136

@JohannesPfeifer JohannesPfeifer force-pushed the JohannesPfeifer:estimation_fixes branch from b509123 to d523333 Oct 4, 2016

@JohannesPfeifer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2016

@houtanb Thanks, I updated the commit

@houtanb houtanb merged commit f074c67 into DynareTeam:master Oct 4, 2016

@JohannesPfeifer JohannesPfeifer deleted the JohannesPfeifer:estimation_fixes branch Oct 4, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.