Fixes #17175 - Added watcher that can terminate a world #211
Conversation
|
We are watching if we mark all futures/events as finished at the end, this was missing ShimShtein#1 |
|
Nitpick: there should be an empty line between subject and body in commit message :) |
| @@ -29,3 +30,7 @@ end | |||
| group :lint do | |||
| gem 'rubocop', '0.39.0' | |||
| end | |||
|
|
|||
| group :memory_watcher do | |||
| gem 'get_process_mem' | |||
There was a problem hiding this comment.
I guess this should belong to the gemspec
There was a problem hiding this comment.
Didn't want to add it to gemspec, since it's optional.
| def initialize(world, memory_limit, options) | ||
| @memory_limit = memory_limit | ||
| @world = world | ||
| @polling_interval = options[:polling_interval] || 10 |
There was a problem hiding this comment.
What about defauling a bit longer: 60s might be enough
| @memory_limit = memory_limit | ||
| @world = world | ||
| @polling_interval = options[:polling_interval] || 10 | ||
| @memory_watcher = options[:memory_watcher] || GetProcessMem.new |
There was a problem hiding this comment.
s/memory_watcher/memory_info_loader or somethng similar, the watcher is this class
|
|
||
| attr_reader :memory_limit, :world | ||
|
|
||
| def initialize(world, memory_limit, options) |
There was a problem hiding this comment.
I would suggest to have an option to have a minimal limit for the world to live (we would need to set @started_at variable in the world, to be able to check this)
The reason would be to prevent immediate termination after the executor starts, without giving it a change to actually do something - this would happen if the limit would be set too low.
There was a problem hiding this comment.
This is why I have added options[:initial_wait] you can pass a longer value in order to give the executor the time it needs to start.
ShimShtein
force-pushed
the
17175
branch
2 times, most recently
from
288e439
to
6277cd2
Compare
|
Fixed everything except moving to gemspec. Now the tests can run. |
|
Technically I approve this, but let's wait for the foreman-tasks portion of the work to test it together, in case we hit some issue here |
This watcher polls the memory size of the process it runs in and terminates the world if memory limit is exceeded. This commit also adds `terminated` event to `World` class, so anyone can add a listener that will perform tasks after a world is terminated.
|
Added an example and fixed a small bug that was not covered by the tests. |
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
|
Thanks @ShimShtein , I still need to do final testing in foreman-tasks, but this part should be good to go. |
|
dynflow-0.8.22 with this code pushed to rubygems |
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
A world will be terminated if memory limit is exceeded. This will cause the running process to be killed. Since we are monitoring our processes, a new process will be spawned. Relies on Dynflow/dynflow#211
This watcher polls the memory size of the process it runs in and terminates the world if memory limit is exceeded.
This commit also adds
terminatedevent toWorldclass, so anyone can add a listener that will perform tasks after a world is terminated.