Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding style issues #1

Closed
3 tasks done
cpinter opened this issue Jan 6, 2022 · 1 comment
Closed
3 tasks done

Fix coding style issues #1

cpinter opened this issue Jan 6, 2022 · 1 comment
Assignees

Comments

@cpinter
Copy link
Contributor

cpinter commented Jan 6, 2022

Style of recently added code is not consistent with the defined style. To facilitate code review (i.e. make reading the code easier, these should be fixed). Typical issues:

  • Indentation is strictly two spaces (not four)
  • Curly braces should always start in new lines, see e.g. here
  • Function separator missing from many places, see what is correct here, and how it is missing e.g. from here
@cpinter
Copy link
Contributor Author

cpinter commented Jan 19, 2022

Please only close issues that you yourself opened. If someone else opens an issue, that person is the one who know what to do and how, and in that case that other person needs to close the issue after a review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants