Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationCredentialsNotFoundException が発生するのを修正 #117

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@nanasess
Copy link
Contributor

nanasess commented Aug 9, 2019

kernel.request event で FRONT_SHOPPING_CONFIRM_INITIALIZE が dispatch された場合は, TokenStorage が有効になっていないため, セッションから自前で復元するように修正

YamatoPayment との組み合わせで発生する。

https://xoops.ec-cube.net/modules/newbb/viewtopic.php?topic_id=22565&forum=16&post_id=94124#forumpost94124

@nanasess nanasess force-pushed the nanasess:fix-tokenstorage branch from e5e70ff to d591aa3 Aug 13, 2019
kernel.request event で FRONT_SHOPPING_CONFIRM_INITIALIZE が dispatch
された場合は, TokenStorage が有効になっていないため, セッションから自
前で復元するように修正

- YamatoPayment との組み合わせで発生する
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 14, 2019

Coverage Status

Coverage decreased (-0.2%) to 63.047% when pulling a409ccf on nanasess:fix-tokenstorage into 5be71a9 on EC-CUBE:3.0.

@hiro-t59 hiro-t59 requested a review from chihiro-adachi Aug 19, 2019
* が dispatch された場合は, TokenStorage が有効になっていないため, セッションから復元する
*/
if ($app['session']->has('_security_customer')) {
$token = unserialize($app['session']->get('_security_customer'));

This comment has been minimized.

Copy link
@chihiro-adachi

chihiro-adachi Aug 20, 2019

Contributor

@nanasess
unserialize使っても問題ないんでしたっけ?
※念の為の確認レベルです

This comment has been minimized.

Copy link
@nanasess

nanasess Aug 20, 2019

Author Contributor

_security_customer はセッションの生情報なので、 PHP serialize されています。
これを復元するのみなので問題ないと思います

This comment has been minimized.

Copy link
@chihiro-adachi

chihiro-adachi Aug 20, 2019

Contributor

承知しました
それなら大丈夫そうですね。
ありがとうございます!

@hiro-t59 hiro-t59 merged commit b427771 into EC-CUBE:3.0 Aug 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kazumiiiiiiiiiii kazumiiiiiiiiiii added this to the 3 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.