Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class LocaleNotFoundException not defined #4683

Closed
l2dy opened this issue Sep 8, 2020 · 2 comments
Closed

Class LocaleNotFoundException not defined #4683

l2dy opened this issue Sep 8, 2020 · 2 comments
Labels
Milestone

Comments

@l2dy
Copy link
Contributor

l2dy commented Sep 8, 2020

概要(Overview)

LocaleNotFoundException is not imported.

} catch (LocaleNotFoundException $exception) {

期待する内容(Expect) or 要望 (Requirement)

e.g.

use Sylius\Component\Locale\Context\LocaleNotFoundException;
[...]

再現手順(Procedure)

環境 (environment)

  • EC-CUBE: 4.0.4
  • PHP: 7.x.x
  • DB:
    • PostgreSQL x.x.x
    • MySQL x.x.x

関連情報 (Ref)

@okazy
Copy link
Contributor

okazy commented Sep 14, 2020

Thanks for your report!
Certainly no LocaleNotFoundException has been imported.
I think it's a remnant of the Sylius process that was used as a reference.
I don't think it's enough to implement LocaleNotFoundException, so I think it should be changed to Exception.

@okazy okazy added the bug:Low label Sep 14, 2020
@okazy okazy added this to the 4.0.x milestone Sep 14, 2020
@okazy okazy closed this as completed in 11412c3 Oct 6, 2020
@okazy
Copy link
Contributor

okazy commented Oct 6, 2020

It is fixed in # 4714 and closed. Thank you.

@okazy okazy modified the milestones: 4.0.x, 4.1 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants