From 726a1979e4a4e7edcd9696c66a55d05fa0416792 Mon Sep 17 00:00:00 2001
From: Kentaro Ohkouchi <nanasess@fsm.ne.jp>
Date: Mon, 8 Apr 2019 18:18:36 +0900
Subject: [PATCH 1/3] Add SC_SessionTest

---
 tests/class/SC_SessionTest.php | 100 +++++++++++++++++++++++++++++++++
 1 file changed, 100 insertions(+)
 create mode 100644 tests/class/SC_SessionTest.php

diff --git a/tests/class/SC_SessionTest.php b/tests/class/SC_SessionTest.php
new file mode 100644
index 0000000000..cb01102d3b
--- /dev/null
+++ b/tests/class/SC_SessionTest.php
@@ -0,0 +1,100 @@
+<?php
+
+class SC_SessionTest extends Common_TestCase
+{
+    /**
+     * @var SC_Session
+     */
+    protected $objSession;
+
+    protected function setUp()
+    {
+        parent::setUp();
+        $_SESSION['cert'] = CERT_STRING;
+        $_SESSION['login_id'] = 'admin';
+        $_SESSION['authority'] = 0;
+        $_SESSION['member_id'] = 1;
+        $_SESSION['uniq_id'] = 'uniqid'; // XXX コンストラクタで使用している未使用変数
+        $this->objSession = new SC_Session_Ex();
+    }
+
+    public function testGetInstance()
+    {
+        $this->assertInstanceOf('SC_Session', $this->objSession);
+        $this->assertNotNull($this->objSession->uniqid, 'コンストラクタで使用している未使用変数');
+    }
+
+    public function testIsSuccess()
+    {
+        $_SERVER['SCRIPT_FILENAME'] = __DIR__.'/../../html/admin/system/index.php';
+        $this->expected = SUCCESS;
+        $this->actual = $this->objSession->IsSuccess();
+        $this->verify();
+    }
+
+    public function testIsSuccessWithAccessError()
+    {
+        $_SESSION['cert'] = 'bad';
+        $this->objSession = new SC_Session_Ex();
+        $this->expected = ACCESS_ERROR;
+        $this->actual = $this->objSession->IsSuccess();
+        $this->verify();
+    }
+
+    public function testIsSuccessWithPermissionError()
+    {
+        $_SERVER['SCRIPT_FILENAME'] = __DIR__.'/../../html/admin/system/index.php';
+        $_SESSION['authority'] = 1;
+        $this->objSession = new SC_Session_Ex();
+        $this->expected = ACCESS_ERROR;
+        $this->actual = $this->objSession->IsSuccess();
+        $this->verify();
+    }
+
+    public function testSetSession()
+    {
+        $this->objSession->SetSession('test', 'value');
+        $this->assertEquals($_SESSION['test'], $this->objSession->GetSession('test'));
+    }
+
+    public function testGetSID()
+    {
+        $this->expected = session_id();
+        $this->actual = $this->objSession->GetSID();
+        $this->assertNotNull($this->actual);
+        $this->verify();
+    }
+
+    public function testGetUniqId()
+    {
+        $_SESSION['uniqid'] = 'uniqid';
+        $this->expected = 'uniqid';
+        $this->actual = $this->objSession->getUniqId();
+        $this->verify();
+    }
+
+    public function testGetUniqIdWithGenerate()
+    {
+        $this->actual = $this->objSession->getUniqId();
+        $this->expected = $_SESSION['uniqid'];
+        $this->verify();
+    }
+
+    public function testLogout()
+    {
+        $this->objSession->logout();
+        $this->assertNull($_SESSION[TRANSACTION_ID_NAME]);
+        $this->assertNull($_SESSION['cert']);
+        $this->assertNull($_SESSION['login_id']);
+        $this->assertNull($_SESSION['authority']);
+        $this->assertNull($_SESSION['member_id']);
+        $this->assertNull($_SESSION['uniqid']);
+    }
+
+    public function testRegenerateSID()
+    {
+        $this->expected = session_id();
+        $this->actual = $this->objSession->regenerateSID();
+        $this->assertNotEquals($this->expected, $this->actual);
+    }
+}

From 9186bc0453ef445bf40f7ca204f03600db60fb75 Mon Sep 17 00:00:00 2001
From: Kentaro Ohkouchi <nanasess@fsm.ne.jp>
Date: Tue, 9 Apr 2019 11:38:17 +0900
Subject: [PATCH 2/3] Fix SC_Session::rgenerateSID()

---
 tests/class/SC_SessionTest.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/class/SC_SessionTest.php b/tests/class/SC_SessionTest.php
index cb01102d3b..2644d96eb7 100644
--- a/tests/class/SC_SessionTest.php
+++ b/tests/class/SC_SessionTest.php
@@ -94,7 +94,8 @@ public function testLogout()
     public function testRegenerateSID()
     {
         $this->expected = session_id();
-        $this->actual = $this->objSession->regenerateSID();
+        $this->objSession->regenerateSID();
+        $this->actual = session_id();
         $this->assertNotEquals($this->expected, $this->actual);
     }
 }

From ccfa74cd89e9e6eace02646caa33794bd3b13a18 Mon Sep 17 00:00:00 2001
From: Kentaro Ohkouchi <nanasess@fsm.ne.jp>
Date: Tue, 9 Apr 2019 17:26:07 +0900
Subject: [PATCH 3/3] Fix regenerateSID

---
 tests/class/SC_SessionTest.php | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/class/SC_SessionTest.php b/tests/class/SC_SessionTest.php
index 2644d96eb7..897e043c9f 100644
--- a/tests/class/SC_SessionTest.php
+++ b/tests/class/SC_SessionTest.php
@@ -94,8 +94,14 @@ public function testLogout()
     public function testRegenerateSID()
     {
         $this->expected = session_id();
-        $this->objSession->regenerateSID();
+        $result = $this->objSession->regenerateSID();
         $this->actual = session_id();
-        $this->assertNotEquals($this->expected, $this->actual);
+
+        if ($result === false) {
+            $this->markTestSkipped('Can not regenerateSID');
+            $this->assertEquals($this->expected, $this->actual);
+        } else {
+            $this->assertNotEquals($this->expected, $this->actual);
+        }
     }
 }