Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

small enhancements for next version #3

Closed
wants to merge 3 commits into from

2 participants

@ChristianBeer

Basically I added a smaller tooltip to the top id links and corrected some minor errors/warnings. I'm just trying to get to know git and github so please forgive me if you don't want code changes this way.

Regards
Christian

ChristianBeer added some commits
@ChristianBeer ChristianBeer fixed radiobutton on index.php
fixed php warning in toprare.php if database is empty
include .gitignore file with my NetBeans exclusions
3e69ef5
@ChristianBeer ChristianBeer synced levelfiltering in detail.php to behave as in index.php
fixed missing image error for detail.php
2e0b5af
@ChristianBeer ChristianBeer fixed missing parameter in style.css
added relative small tooltip to top10byid with full explanation
3f565e9
@ECSC
Owner

Many thanks Christian, these have been applied!

I didn't 'merge' as I am really working on the code here locally (pushing to git now and again).

You will see them very soon :)

Andy

@ECSC ECSC closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 29, 2012
  1. @ChristianBeer

    fixed radiobutton on index.php

    ChristianBeer authored
    fixed php warning in toprare.php if database is empty
    include .gitignore file with my NetBeans exclusions
  2. @ChristianBeer

    synced levelfiltering in detail.php to behave as in index.php

    ChristianBeer authored
    fixed missing image error for detail.php
  3. @ChristianBeer

    fixed missing parameter in style.css

    ChristianBeer authored
    added relative small tooltip to top10byid with full explanation
This page is out of date. Refresh to see the latest.
View
3  .gitignore
@@ -0,0 +1,3 @@
+/nbproject/private/
+/nbproject/project.xml
+/nbproject/project.properties
View
6 detail.php
@@ -15,7 +15,7 @@
# where = the cumulative sql command
## filter criteria 'level'
-if(isset($_GET['level']) && is_numeric($_GET['level']) && $_GET['level']>0){
+if(isset($_GET['level']) && is_numeric($_GET['level']) && $_GET['level']>=0){
$inputlevel=$_GET['level'];
$where.="AND signature.level>=".$inputlevel." ";
}else{
@@ -186,7 +186,7 @@
chart.startDuration = 0.5;
chart.balloon.color = "#000000";
chart.zoomOutOnDataUpdate=true;
- chart.pathToImages = "/images/";
+ chart.pathToImages = "./images/";
chart.zoomOutButton = {
backgroundColor: '#000000',
backgroundAlpha: 0.15
@@ -281,7 +281,7 @@ function setPanSelect() {
<div class='fleft filters'>
Level<br/>
<select name='level' style='font-size:12px' >
- <option value='0'>--</option>
+ <option value=''>--</option>
<?php echo $filterlevel; ?>
</select>
</div>
View
7 index.php
@@ -8,7 +8,7 @@
## filter criteria 'level'
-if(isset($_GET['level']) && is_numeric($_GET['level']) && $_GET['level']>0){
+if(isset($_GET['level']) && is_numeric($_GET['level']) && $_GET['level']>=0){
$inputlevel=$_GET['level'];
}else{
$inputlevel=$glb_level;
@@ -36,7 +36,10 @@
$radiosource="";
$radiopath="";
$radiolevel="";
-if(isset($_GET['field']) && $_GET['field']=='path'){
+if(isset($_GET['field']) && $_GET['field']=='source'){
+ $radiosource="checked";
+}elseif(isset($_GET['field']) && $_GET['field']=='path'){
+
$radiopath="checked";
}elseif(isset($_GET['field']) && $_GET['field']=='level'){
$radiolevel="checked";
View
2  php/topid.php
@@ -32,7 +32,7 @@
while($row = @mysql_fetch_assoc($result)){
$mainstring.="<div class='fleft top10data' style='width:60px'>".$row['res_cnt']."</div>
- <div class='fleft top10data'><a class='top10data' href='./detail.php?rule_id=".$row['res_rule']."&from=".$from."&breakdown=source'>".htmlspecialchars(substr($row['res_desc'], 0, 28))."...</a></div>
+ <div class='fleft top10data'><a class='top10data tooltip_small' href='./detail.php?rule_id=".$row['res_rule']."&from=".$from."&breakdown=source'>".htmlspecialchars(substr($row['res_desc'], 0, 28))."...<span>".htmlspecialchars($row['res_desc'])."</span></a></div>
<div class='clr'></div>";
}
$mainstring.="";
View
2  php/toprare.php
@@ -46,7 +46,7 @@
$i=0;
$mainstring="";
foreach ($lastrare as $key => $val) {
- if($i<$glb_indexsubtablelimit){
+ if($i<$glb_indexsubtablelimit && trim($val)!="||"){
$display=explode("||", $val);
$mainstring.="<div class='fleft top10data' style='width:90px;'>".date("dS M H:i", $display[0])."</div>
<div class='fright top10data' style='text-align:right; width:*' ><a class='top10data' href='./detail.php?rule_id=".$key."&breakdown=source'>".htmlspecialchars($display[1])."</a></div>
View
25 style.css
@@ -12,7 +12,7 @@ div{border-style:solid;margin:0px; border-style:solid;border-width:0px;}
.maincol{width:33%}
-.top10header{text-transform: font-weight: bold;border-left: 6px solid #005482; color: #363636; font-size: 20px; padding: 7px 0 7px 10px;font-family: Helvetica,Arial,sans-serif;}
+.top10header{text-transform: capitalize; font-weight: bold;border-left: 6px solid #005482; color: #363636; font-size: 20px; padding: 7px 0 7px 10px;font-family: Helvetica,Arial,sans-serif;}
.top10data{text-transform: capitalize; font-weight: bold; color: #363636; font-size: 12px; font-family: Helvetica,Arial,sans-serif;padding-left:1px;}
@@ -142,3 +142,26 @@ border-bottom: 0;
border-top-color: #ccc;
bottom: -8px;
}
+
+a.tooltip_small {
+ position: relative;
+}
+
+a.tooltip_small span {
+ display: none;
+ text-decoration: none;
+}
+
+a.tooltip_small:hover span {
+ display: block;
+ position: absolute;
+ top: 0px;
+ left: 200px;
+ width: 200px;
+ z-index: 100;
+ color: #fff;
+ background: #005482;
+ text-align: left;
+ text-decoration: none;
+ font-weight: normal;
+}
Something went wrong with that request. Please try again.