-
Notifications
You must be signed in to change notification settings - Fork 111
generate quality circuit diagrams #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
scbarton got a pretty sweet draw_circuit function started in #25. Testing more complex functions and documentation could be a great first contributor/Hack Week project. |
I have code from our last hack week that mostly implements this. One of the problems is that not all elements are represented in the circuit library in SchemDraw, IIRC. I'll try to make time to review this over the next week. It is also against a nearly one year old fork so that will need to reconciled. |
Great! Let me know if/how I can help |
Writing good tests is going to be a challenge. |
Yeah... I could see that. I think it'd be possible to come up with some edge cases (nested parallel/series elements, etc.) but testing/ensuring that it works globally seems challenging. Maybe we just check the circuit complexity and warn the user if it's beyond a typical (i.e. tested) use case. Realistically, there are physical constraints on what complexity of circuit makes sense if that's helpful. |
The circuit drawing feature is not yet there in the library, right? |
Have had a few requests for the ability to export a circuit to a pdf/svg/png
After some poking around I think SchemDraw (https://cdelker.bitbucket.io/SchemDraw/SchemDraw.html) seems like a good way to do it
The text was updated successfully, but these errors were encountered: