Skip to content

generate quality circuit diagrams #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdmurbach opened this issue Oct 6, 2018 · 6 comments
Open

generate quality circuit diagrams #13

mdmurbach opened this issue Oct 6, 2018 · 6 comments
Labels
ECS Hack Week A good issue for the ECS Hack Week hacking good first issue Good for newcomers

Comments

@mdmurbach
Copy link
Member

Have had a few requests for the ability to export a circuit to a pdf/svg/png

After some poking around I think SchemDraw (https://cdelker.bitbucket.io/SchemDraw/SchemDraw.html) seems like a good way to do it

@mdmurbach mdmurbach added ECS Hack Week A good issue for the ECS Hack Week hacking good first issue Good for newcomers labels May 20, 2019
@mdmurbach
Copy link
Member Author

scbarton got a pretty sweet draw_circuit function started in #25. Testing more complex functions and documentation could be a great first contributor/Hack Week project.

@dacb
Copy link
Contributor

dacb commented Feb 26, 2020

I have code from our last hack week that mostly implements this. One of the problems is that not all elements are represented in the circuit library in SchemDraw, IIRC. I'll try to make time to review this over the next week. It is also against a nearly one year old fork so that will need to reconciled.

@mdmurbach
Copy link
Member Author

Great! Let me know if/how I can help

@beckdac
Copy link

beckdac commented Feb 27, 2020

Writing good tests is going to be a challenge.

@mdmurbach
Copy link
Member Author

Yeah... I could see that.

I think it'd be possible to come up with some edge cases (nested parallel/series elements, etc.) but testing/ensuring that it works globally seems challenging. Maybe we just check the circuit complexity and warn the user if it's beyond a typical (i.e. tested) use case. Realistically, there are physical constraints on what complexity of circuit makes sense if that's helpful.

@BGerwe BGerwe moved this to To prioritize in Maintenance Blitz Sep 18, 2022
@Yugal0
Copy link

Yugal0 commented Aug 19, 2023

The circuit drawing feature is not yet there in the library, right?
or it is that I have an older distribution,
Also, can someone tell me what the schedule is for releasing a new distribution of the library on pip (the python package installer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECS Hack Week A good issue for the ECS Hack Week hacking good first issue Good for newcomers
Projects
Status: To prioritize
Development

No branches or pull requests

4 participants