topViewSnapshot needs a new frame when setting topViewController #80

Merged
merged 1 commit into from Sep 12, 2013

Projects

None yet

2 participants

@pennig
Contributor
pennig commented Jan 28, 2013

Reason for this addition is that the snapshot gets a zero rect if topViewController is set late in the game — in my case, after viewWillAppear is called. So I'm resetting the frame whenever topViewController is set. Fixed my use case.

Perhaps it's more appropriate to call adjustLayout instead of setting the frame directly, as the left and right viewControllers could also need updating in some scenarios which I can't fathom.

@pennig pennig Update ECSlidingViewController/Vendor/ECSlidingViewController/ECSlidi…
…ngViewController.m

Update the snapshot's frame when setting the topViewController. Ensures the snapshot appears properly if topViewController is added late (e.g., after viewWillAppear)
f348514
@enriquez enriquez merged commit 7963fe9 into ECSlidingViewController:master Sep 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment