-
Notifications
You must be signed in to change notification settings - Fork 68
add support for alternative artefacts checks in check-build.sh #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Instance
|
|
Instance
|
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think @laraPPr is planning a test PR on top of this to make sure this doesn't cause trouble, but it looks fine to me (didn't test it hands-on).
laraPPr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
PR merged! Moved |
1 similar comment
|
PR merged! Moved |
if
USE_CHECK_BUILD_ARTEFACTS_SCRIPT=1is set, checking the tarball is skipped. instead,check-build-artefacts.shis sourced, which may do alternative artefacts checks.by default,
USE_CHECK_BUILD_ARTEFACTS_SCRIPT=0, thus no change in behavior should be observedthis is useful for installations that are done directly on the system instead of CVMFS.
the changes are rather small if you hide the whitespace differences ;)
@boegel @laraPPr