Skip to content

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented Jan 5, 2025

if USE_CHECK_BUILD_ARTEFACTS_SCRIPT=1 is set, checking the tarball is skipped. instead, check-build-artefacts.sh is sourced, which may do alternative artefacts checks.

by default, USE_CHECK_BUILD_ARTEFACTS_SCRIPT=0, thus no change in behavior should be observed

this is useful for installations that are done directly on the system instead of CVMFS.

the changes are rather small if you hide the whitespace differences ;)

@boegel @laraPPr

@eessi-bot
Copy link

eessi-bot bot commented Jan 5, 2025

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software

@eessi-bot
Copy link

eessi-bot bot commented Jan 5, 2025

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi.io-2023.06-compat, eessi.io-2023.06-software

boegel
boegel previously approved these changes Jan 30, 2025
Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I think @laraPPr is planning a test PR on top of this to make sure this doesn't cause trouble, but it looks fine to me (didn't test it hands-on).

laraPPr pushed a commit to laraPPr/software-layer that referenced this pull request Jan 30, 2025
Copy link
Collaborator

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 51a1006 into EESSI:2023.06-software.eessi.io Jan 31, 2025
49 checks passed
@eessi-bot
Copy link

eessi-bot bot commented Jan 31, 2025

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2025.01.31

1 similar comment
@eessi-bot
Copy link

eessi-bot bot commented Jan 31, 2025

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2025.01.31

@laraPPr laraPPr mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants