Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS Everywhere causes interstitial warning pages on Google Images #1096

Closed
cypherpunk opened this issue Feb 18, 2015 · 13 comments
Closed

HTTPS Everywhere causes interstitial warning pages on Google Images #1096

cypherpunk opened this issue Feb 18, 2015 · 13 comments

Comments

Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@cypherpunk @semenko @jsha @IBBoard @fuzzyroddis and others
@jsha
Copy link
Member

@jsha jsha commented Feb 18, 2015

It looks like this is caused by Google's redirect page being rewritten to www.google.com instead of www.google.co.uk which it should be. I'm guessing the psig parameter is a signature over the URL that includes the hostname (but potentially not the scheme), and that signature fails after rewrite, prompting the interstitial.

@cypherpunk
Copy link
Contributor Author

@cypherpunk cypherpunk commented Feb 19, 2015

It seems like this happens on all Google sites except for google.com. Is there any other way to fix this than to disable https on Google Images?

@jsha
Copy link
Member

@jsha jsha commented Feb 19, 2015

Yes, I think we can fix it at the ruleset level for the next release. Unfortunately in the meantime I think the only way to fix it is to disable that ruleset in your browser.

@fuzzyroddis
Copy link
Contributor

@fuzzyroddis fuzzyroddis commented Feb 21, 2015

@cypherpunk what version of HTTPS Everywhere are you using?

@cypherpunk
Copy link
Contributor Author

@cypherpunk cypherpunk commented Feb 23, 2015

@StevenRoddis I'm using HTTPS Everywhere 4.0.3.

@fuzzyroddis
Copy link
Contributor

@fuzzyroddis fuzzyroddis commented Mar 9, 2015

My branch still doesn't fix this. I plan to address this in the future.
I'm curious how one lands on /imgres I haven't worked that out. Do you use NoScript?

@IBBoard
Copy link

@IBBoard IBBoard commented Mar 9, 2015

I hit this interstitial as well. I'm not using NoScript, but I am using Ghostery and AdBlock Plus. You can end up on the /imgres page if you middle-click to open in a new tab (so it doesn't load the dark grey page as inline content). Whether I middle-click or left-click then the "View Image" button drops me to the confirmation interstitial next.
If I edit the URL of the interstitial from ".com" to ".co.uk" (which is what the search was initiated from) then I do get the image straight away.

jsha added a commit to jsha/https-everywhere that referenced this issue Mar 12, 2015
The url parameter tbm=isch indicates a Google Images page clicked through from
the search results page. It's not clear why this rule wound up in GoogleVideos,
but that rule was overriding an exclusion for image pages and causing breakage.

See EFForg#1096 and
EFForg#933
@cypherpunk
Copy link
Contributor Author

@cypherpunk cypherpunk commented Mar 16, 2015

Maybe we could ask Google to fix this since the problem is on their end?

@cypherpunk
Copy link
Contributor Author

@cypherpunk cypherpunk commented Apr 14, 2015

These interstitial warning pages are still appearing.

@IBBoard
Copy link

@IBBoard IBBoard commented Oct 3, 2015

I'm not getting interstitials any more, but I've just realised that I'm getting the HTTPS → HTTP redirect behaviour that @fuzzyroddis mentioned. I don't know when that changed for me.

I'm running 5.1.1.

@semenko
Copy link
Contributor

@semenko semenko commented Dec 17, 2015

Tentatively closing, since I haven't seen this in a while -- likely fixed on Google's end.

Please reopen / comment if you see it again.

@semenko semenko closed this Dec 17, 2015
@IBBoard
Copy link

@IBBoard IBBoard commented Dec 18, 2015

Confirmed that I'm not seeing it now, and the dark grey "View Image"/"Visit Page" page is on HTTPS and doesn't get forced to HTTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment