Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error: "window.controllers is deprecated" #510

Closed
diracdeltas opened this issue Aug 29, 2014 · 0 comments
Closed

Console error: "window.controllers is deprecated" #510

diracdeltas opened this issue Aug 29, 2014 · 0 comments

Comments

Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@semenko @diracdeltas and others
@diracdeltas
Copy link
Contributor

@diracdeltas diracdeltas commented Aug 29, 2014

To repro, visit a page like https://developer.mozilla.org/en-US/docs/Glossary/Expando in Firefox and watch the javascript console.

HTTPS Everywhere uses custom window controllers in the getExpando and setExpando methods, where the expando is essentially the list of applicable rules for a given DOM window. Mozilla folks tell me that we should be using WeakMaps keyed by the window instead of StorageControllers (which is what Privacy Badger Firefox does). IIRC, our expando implementation isn't e10s compatible anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment