Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

[FAZ] fix regex mistakes #1099

Closed
wants to merge 1 commit into from
Closed

Conversation

arthuredelstein
Copy link
Contributor

Incorrect capturing group references in this file. Once fixed, faz.net appears to load without a problem.

@jsha
Copy link
Member

jsha commented Feb 20, 2015

Hi @arthuredelstein! Thanks for the fix. Right now we're only accepting modifications to rules that also bring them up to date with the ruleset coverage testing rules. If you have time to do that, that'd be great. If you don't, just update the <ruleset> tag to have 'default_off="needs ruleset tests"', and we can merge as-is until someone has time to update the rule for testing.

@semenko
Copy link
Contributor

semenko commented Sep 7, 2015

Hey @arthuredelstein -- thanks for these!

If you'd like to have these rules merged, please make the changes @jsha suggested and comment here or open another PR. (Closing for now because it's been untouched for 6+ months.)

@semenko semenko closed this Sep 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants