Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Embedded WebExtension #11760
In addition, this includes various fixes to the functionality of the WebExtensions code to make it work gracefully in Firefox, cherry-picked from the
Embedded webextensions will be deprecated as of Firefox 57 as well, so this is merely an intermediate step to enable us to have users' settings migrated.
Additionally, this includes a new options ui to allow users to import a json file with settings. Since this replaces #11639, there will be no way for users to export previous settings yet. This won't be a problem, since Embedded WebExtensions are able to transfer settings automatically via the
@koops76 I've been testing all along, but there are bound to be edge cases. Any beta-testers that that want to install this are welcome to, but this combines the work over many months of enumerating bugs in the Firefox WebExtension code and pushing out fixes. What's new in this PR is the migration code as well as the XPCOM wrapper.
If you're referring to the testing framework, we have been using the addon-sdk to install a separate extension to test functionality in Firefox. The Jetpack SDK addons will be deprecated just as XPCOM will, so we can no longer use this. I've changed the Firefox tests to use Selenium just as the Chrome tests do. This means we're confined to the bounds of the Selenium API, and currently our coverage is limited. Building this out is a future task.…
On August 8, 2017 5:37:58 PM PDT, koops76 ***@***.***> wrote: @Hainish I hope you didn't sacrifice testing to make this come out earlier? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #11760 (comment)
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.