New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calculator.net.xml #13372

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@andschwa
Contributor

andschwa commented Oct 28, 2017

I ran the tests, built the XPI, installed it (in Developer edition with legacy extensions enabled, can't figure out how to build the Firefox WebExtension I guess?), and tested. It's redirecting correctly. The site is fairly simple (but great), no assets fail to load.

@andschwa

This comment has been minimized.

Contributor

andschwa commented Oct 28, 2017

Note: I highly recommend adding this website, since it has a mortgage calculator, which some people (ahem me) use with what they consider rather personal information.

@andschwa

This comment has been minimized.

Contributor

andschwa commented Oct 28, 2017

Also, I generated the rule with make-trivial-rule calculator.net :)

@Hainish Hainish added the top-10k label Oct 28, 2017

@J0WI

This comment has been minimized.

Collaborator

J0WI commented Oct 28, 2017

Thanks!

@J0WI J0WI merged commit 43dd23d into EFForg:master Oct 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@J0WI J0WI added the new-ruleset label Oct 28, 2017

@andschwa andschwa deleted the andschwa:calculator-net branch Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment