From 1338ec376938a40fb7bb9b468d469f69798ee069 Mon Sep 17 00:00:00 2001 From: cschanaj Date: Sat, 19 Dec 2020 05:05:13 +0100 Subject: [PATCH 1/3] Install the latest geckodriver for firefox --- test/setup_travis.sh | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/setup_travis.sh b/test/setup_travis.sh index 76f710d9dad3..2e5d19c78d7c 100755 --- a/test/setup_travis.sh +++ b/test/setup_travis.sh @@ -17,11 +17,14 @@ function setup_chrome { } function setup_firefox { - #version=$(curl -s https://api.github.com/repos/mozilla/geckodriver/releases/latest | grep tag_name | cut -d '"' -f 4) - # hard-code latest version, since apparently the above `curl` is fucking up in travis - version="v0.26.0" - url="https://github.com/mozilla/geckodriver/releases/download/${version}/geckodriver-${version}-linux64.tar.gz" - wget -O /tmp/geckodriver.tar.gz ${url} + # install the latest version of geckodriver (per Github release API) + firefox_version=$("${BROWSER}" -version) + geckodriver_version=$(curl -s https://api.github.com/repos/mozilla/geckodriver/releases/latest | grep tag_name | cut -d '"' -f 4) + geckodriver_url="https://github.com/mozilla/geckodriver/releases/download/${version}/geckodriver-${version}-linux64.tar.gz" + + echo "Setting up geckodriver ${geckodriver_version} for ${1} ${firefox_version}" + + wget -O /tmp/geckodriver.tar.gz ${geckodriver_url} sudo tar -xvf /tmp/geckodriver.tar.gz -C /usr/local/bin/ sudo chmod a+x /usr/local/bin/geckodriver } From 38f993013cab2611d8237f39d105ddb0ce8f223e Mon Sep 17 00:00:00 2001 From: Chan Chak Shing Date: Sat, 19 Dec 2020 05:08:37 +0100 Subject: [PATCH 2/3] Update setup_travis.sh --- test/setup_travis.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/setup_travis.sh b/test/setup_travis.sh index 2e5d19c78d7c..5b9d08770eee 100755 --- a/test/setup_travis.sh +++ b/test/setup_travis.sh @@ -20,7 +20,7 @@ function setup_firefox { # install the latest version of geckodriver (per Github release API) firefox_version=$("${BROWSER}" -version) geckodriver_version=$(curl -s https://api.github.com/repos/mozilla/geckodriver/releases/latest | grep tag_name | cut -d '"' -f 4) - geckodriver_url="https://github.com/mozilla/geckodriver/releases/download/${version}/geckodriver-${version}-linux64.tar.gz" + geckodriver_url="https://github.com/mozilla/geckodriver/releases/download/${geckodriver_version}/geckodriver-${geckodriver_version}-linux64.tar.gz" echo "Setting up geckodriver ${geckodriver_version} for ${1} ${firefox_version}" From e8a45bf809d6e19d3d6e95132afd628e809baf02 Mon Sep 17 00:00:00 2001 From: Chan Chak Shing Date: Sat, 19 Dec 2020 05:24:15 +0100 Subject: [PATCH 3/3] Update setup_travis.sh --- test/setup_travis.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/setup_travis.sh b/test/setup_travis.sh index 5b9d08770eee..53e4c747cd37 100755 --- a/test/setup_travis.sh +++ b/test/setup_travis.sh @@ -22,7 +22,7 @@ function setup_firefox { geckodriver_version=$(curl -s https://api.github.com/repos/mozilla/geckodriver/releases/latest | grep tag_name | cut -d '"' -f 4) geckodriver_url="https://github.com/mozilla/geckodriver/releases/download/${geckodriver_version}/geckodriver-${geckodriver_version}-linux64.tar.gz" - echo "Setting up geckodriver ${geckodriver_version} for ${1} ${firefox_version}" + echo "Setting up geckodriver ${geckodriver_version} for ${firefox_version}" wget -O /tmp/geckodriver.tar.gz ${geckodriver_url} sudo tar -xvf /tmp/geckodriver.tar.gz -C /usr/local/bin/