Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getbootstrap.com #6731

Merged
merged 2 commits into from Sep 6, 2016
Merged

getbootstrap.com #6731

merged 2 commits into from Sep 6, 2016

Conversation

Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@galeksandrp
Copy link
Contributor

@galeksandrp galeksandrp commented Sep 2, 2016

Fix https://trac.torproject.org/projects/tor/ticket/19396

@J0WI
Copy link
Collaborator

@J0WI J0WI commented Sep 2, 2016

Please also leave a comment in the rule about the issue there.

@galeksandrp galeksandrp force-pushed the getbootstrap.com branch from fca3d92 to c2f1dc8 Sep 2, 2016
@galeksandrp
Copy link
Contributor Author

@galeksandrp galeksandrp commented Sep 2, 2016

Added.

@fuglede
Copy link
Contributor

@fuglede fuglede commented Sep 2, 2016

The site appears to work fine for me, and in particular I did not notice any redirect loops. Are there any specific steps to reproduce?

@jeremyn
Copy link
Contributor

@jeremyn jeremyn commented Sep 2, 2016

@fuglede The torproject bug labels it specifically for Chrome. I can't reproduce it on Firefox, and I can't test it on Chrome because of the #5874 .

@jeremyn
Copy link
Contributor

@jeremyn jeremyn commented Sep 5, 2016

Now that there's a fix/workaround for #5874 , I can confirm that https://themes.getbootstrap.com/products/dashboard loops in Chrome but not Firefox.

@jeremyn
Copy link
Contributor

@jeremyn jeremyn commented Sep 5, 2016

@galeksandrp galeksandrp force-pushed the getbootstrap.com branch from c2f1dc8 to e0a7902 Sep 6, 2016
@galeksandrp
Copy link
Contributor Author

@galeksandrp galeksandrp commented Sep 6, 2016

Updated.

@J0WI
Copy link
Collaborator

@J0WI J0WI commented Sep 6, 2016

I wonder why this works in Firefox, because of the

  <!-- sad hack because github pages doesn't support https -->
  <script>
     if (window.location.protocol == "https:") window.location.protocol = "http:"
  </script>

Console shows

NS_ERROR_UNEXPECTED:   dashboard:6
    <anonymous> https://themes.getbootstrap.com/products/dashboard:6:48

@jeremyn jeremyn merged commit 01b8e8d into EFForg:master Sep 6, 2016
1 check passed
@jeremyn
Copy link
Contributor

@jeremyn jeremyn commented Sep 6, 2016

@J0WI I didn't dig into too much but it looks like this is a thing with Firefox, see here and here for example.

@fuglede
Copy link
Contributor

@fuglede fuglede commented Sep 6, 2016

I contacted the webmasters regarding the issue.

@fuglede
Copy link
Contributor

@fuglede fuglede commented Oct 9, 2016

And here's their response:

We appreciate you letting us know – it's an unfortunate necessity. Basically the way Shopify works it required us to force just the product pages to be insecure to iFrame our content in without issue
in some situations. It wasn't our favorite either, but was the only surefire way to solve the issue without basically getting Shopify to accept a feature request. That said, every other page is
secure, so we figured we could deal with the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment