Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Urgent: fix redirect loops for meta.*.stackexchange.com #9110
Long-term, we can narrow this entire rule set down to the blogs, all other domains are getting HTTPS support and HSTS headers.
This is an urgent issue since users of HTTPS Everywhere are currently getting redirect loops from us rolling out HTTPS support here. It's also my first time modifying these rulesets, if I'm doing something completely incorrectly please let me know and I'll fix it ASAP, or feel free to do so on your end, whatever fixes redirects for our combined user base faster. Thanks!
I don't think the failure here is related to my commit, it appears to be from #6494 earlier, which also gave me odd behavior locally. It was a hurdle to running tests. I assumed it was my setup, but it appears to have broken every PR since on the build system as well.
I've merged #9107, so that problem is gone.
@NickCraver I can merge this as-is, but a few comments, mainly for your reference and the reference of anyone else reading this:
I'm a little unhappy with the https://blog.gaming.stackexchange.com
If possible, in this comment:
<!-- meta.* sites moved to *.meta - we can safely redirect to their new equivalents, which support https -->
add a link to a StackExchange blog post or something saying this redirect is actually safe to do. I believe you, since you're the site administrator, but a reviewer looking at this ruleset a year from now without context might not know what to do with that assertion.
Did you test your changes in the
Let me know when you're ready and I'll merge this.
@jeremyn All good notes, thanks! I was me trying to strictly maintain the old behavior for blog which really isn't necessary -
I tested using the automated suite, but don't I have/use Firefox on my Macbook which was the easiest place to deal with this repo.