Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is privacy-badger blocking Discourse from loading correctly? #1953

Closed
aschrijver opened this issue Apr 9, 2018 · 8 comments
Closed

Is privacy-badger blocking Discourse from loading correctly? #1953

aschrijver opened this issue Apr 9, 2018 · 8 comments

Comments

@aschrijver
Copy link

aschrijver commented Apr 9, 2018

There was a "Cannot load App" for meta-topic" on Discourse Meta a while ago

Discourse Error After Revisiting Firefox Tab

In that case it was uBlock that was the cause, but I now have this issue with Firefox 58, both on Ubuntu and Android, and it seems related to Privacy Badger (see also my original post on meta.discourse.org).

The issue occurs when resuming Ubuntu session, or reopening Samsung phone browser, after period of inactivity. Sometimes the privacy-badger menu shows an empty dialog (no chrome to disable PB), sometimes it shows '0 trackers' (just pertains to the error page). Disabling PB and then the page displays again. I use PB 2018.3.21 and have the issue on multiple forums (e.g. Humane Technology and Meta)

When not disabling, on Android a refresh page is sufficient to get the correct view back, but on Ubuntu opening an entirely fresh tab is required.

Edit: I just noticed that in my Ubuntu FF browser when opening meta.discourse.org PB is showing the empty menu screen, and is not getting triggered at all, unless restarting the browser (with saved tabs).

@ghostwords
Copy link
Member

At least some of this appears to be a Discourse/Firefox bug unrelated to Privacy Badger. If I open Firefox in a fresh profile, visit a Discourse Meta page and restart Firefox, I get the same error screen (see below). No extensions loaded.

screenshot from 2018-04-09 16 05 00

@ghostwords
Copy link
Member

Privacy Badger-wise, why do I see the "not-a-valid-HTTP-page" screen on Discourse pages sometimes? It seems to happen to the second page when I have two pages opened, but I am not sure yet. Only seems to happen in Firefox.

screenshot from 2018-04-09 16 13 30

@ghostwords
Copy link
Member

So I am not sure Privacy Badger is responsible for your problem (since I can reproduce without Privacy Badger) but something weird is going on here (Privacy Badger's popup is in the wrong state sometimes).

@aschrijver
Copy link
Author

Thanks a lot for your time and effort @ghostwords !! I am not familiar in both codebases.. will report back to the Discourse thread!

@xfalcox
Copy link

xfalcox commented Apr 9, 2018

Discourse implements the minimum necessary service worker to show the "Add to Homescreen"/PWA banner.

It was extracted from https://googlechrome.github.io/samples/service-worker/custom-offline-page/ so I believe many sites will have a similar implementation.

@ghostwords: At least some of this appears to be a Discourse/Firefox bug unrelated to Privacy Badger. If I open Firefox in a fresh profile, visit a Discourse Meta page and restart Firefox, I get the same error screen (see below). No extensions loaded.

Yes, this is a bug in Firefox "Session Restore". It doesn't restart the service workers or something like that.

@ghostwords
Copy link
Member

This is related to (or is the same issue as) #1144.

We should figure out what the Firefox bug is exactly, and then see if this is an existing Mozilla Bugzilla issue and report it if it's not.

There seem to be reports of similar situations in our error reports database. What stands out is that the one reported blocked domain is also the site domain.

@aschrijver
Copy link
Author

I think this might be solved in FF 60.0. I am not entirely sure, but don't remember having seen the issue since I upgraded. Not on Android mobile nor on my Ubuntu laptop.

@ghostwords
Copy link
Member

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1499523#c4, this should be fixed in Firefox when "Service worker e10s redesign" is complete. We may release workarounds in Privacy Badger before then, however.

Closing as a duplicate of #1144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants