Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: wired connection is shown as "Ping: none" #3

Closed
bersbersbers opened this issue Jul 16, 2020 · 4 comments
Closed

Bug: wired connection is shown as "Ping: none" #3

bersbersbers opened this issue Jul 16, 2020 · 4 comments

Comments

@bersbersbers
Copy link

bersbersbers commented Jul 16, 2020

This is my network setup as seen from tracert:

>tracert 8.8.8.8

Tracing route to 8.8.8.8 over a maximum of 30 hops

  1     1 ms    <1 ms    <1 ms  10.0.0.6
  2     4 ms     2 ms     2 ms  10.0.0.1
  3    10 ms    10 ms     9 ms  xxx
  4    11 ms    11 ms    11 ms  xxx
  5    21 ms    21 ms    19 ms  xxx
  6    20 ms    20 ms    20 ms  xxx
  7    21 ms    22 ms    20 ms  172.253.64.119
  8    20 ms    20 ms    19 ms  8.8.8.8

So I have three PingoMeters running for 10.0.0.6, 10.0.0.1, and 8.8.8.8, where for first one is shown as "Ping: none" intermittently.
image

Could it be that the 10.0.0.6 one is too fast and is shown as "Ping: none" incorrectly? I am referring to this piece of code:

default:
// OK. В остальных случиях получим исключение
DrawGraph(reply.RoundtripTime);

private void DrawGraph(long value)
{
if (value == -1)
{
notifyIcon.Icon = Icon.FromHandle(hiconOriginal);
return;
}
if (value == 0L)
{
//g.DrawLine(Pens.Black, 15, 15, 15, 1);
notifyIcon.Text = "Ping: none";
}

It seems to me like value == 0L is not necessarily an exception.

@bersbersbers
Copy link
Author

Commenting out these lines fixes the issue:

if (value == 0L)
{
//g.DrawLine(Pens.Black, 15, 15, 15, 1);
notifyIcon.Text = "Ping: none";
}

@EFLFE
Copy link
Owner

EFLFE commented Aug 25, 2020

Thanks for the report. I will fix it soon.

@EFLFE
Copy link
Owner

EFLFE commented Oct 7, 2020

I think the problem is solved?

@bersbersbers
Copy link
Author

Yes! I had re-built the app myself with the proposed fix, but I also verified 0.9.5 now and it's working well. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants