From 5ea288da9bca15b0c21d6386247d56dc1f521bac Mon Sep 17 00:00:00 2001
From: Tobias Megies <tobias.megies@lmu.de>
Date: Thu, 28 May 2026 15:53:31 +0200
Subject: [PATCH] slightly safer config variable setting

could make an actual difference if the desired value is set as an OS
environment variable and if that value evaluates to False with bool()

E.g. if trying to set an empty string or the number zero it might
inadvertantly get overridden by the default value from config
---
 config.py.sample | 36 ++++++++++++++++--------------------
 1 file changed, 16 insertions(+), 20 deletions(-)

diff --git a/config.py.sample b/config.py.sample
index dc482e7..59613ab 100644
--- a/config.py.sample
+++ b/config.py.sample
@@ -43,28 +43,24 @@ class Config:
         CACHE_RESP_PERIOD = 1200
 
     try:
-        MONGODB_HOST = os.environ.get("MONGODB_HOST") or MONGODB_HOST
-        MONGODB_PORT = os.environ.get("MONGODB_PORT") or MONGODB_PORT
-        MONGODB_USR = os.environ.get("MONGODB_USR") or MONGODB_USR
-        MONGODB_PWD = os.environ.get("MONGODB_PWD") or MONGODB_PWD
-        MONGODB_NAME = os.environ.get("MONGODB_NAME") or MONGODB_NAME
-        FDSNWS_STATION_URL = os.environ.get("FDSNWS_STATION_URL") or FDSNWS_STATION_URL
-        CACHE_HOST = os.environ.get("CACHE_HOST") or CACHE_HOST
-        CACHE_PORT = os.environ.get("CACHE_PORT") or CACHE_PORT
-        CACHE_INVENTORY_KEY = (
-            os.environ.get("CACHE_INVENTORY_KEY") or CACHE_INVENTORY_KEY
-        )
-        CACHE_INVENTORY_PERIOD = (
-            os.environ.get("CACHE_INVENTORY_PERIOD") or CACHE_INVENTORY_PERIOD
-        )
-        CACHE_RESP_PERIOD = (
-            os.environ.get("CACHE_SHORT_INV_PERIOD") or CACHE_RESP_PERIOD
-        )
+        MONGODB_HOST = os.environ.get("MONGODB_HOST", MONGODB_HOST)
+        MONGODB_PORT = os.environ.get("MONGODB_PORT", MONGODB_PORT)
+        MONGODB_USR = os.environ.get("MONGODB_USR", MONGODB_USR)
+        MONGODB_PWD = os.environ.get("MONGODB_PWD", MONGODB_PWD)
+        MONGODB_NAME = os.environ.get("MONGODB_NAME", MONGODB_NAME)
+        FDSNWS_STATION_URL = os.environ.get("FDSNWS_STATION_URL", FDSNWS_STATION_URL)
+        CACHE_HOST = os.environ.get("CACHE_HOST", CACHE_HOST)
+        CACHE_PORT = os.environ.get("CACHE_PORT", CACHE_PORT)
+        CACHE_INVENTORY_KEY = os.environ.get(
+            "CACHE_INVENTORY_KEY", CACHE_INVENTORY_KEY)
+        CACHE_INVENTORY_PERIOD = os.environ.get(
+            "CACHE_INVENTORY_PERIOD", CACHE_INVENTORY_PERIOD)
+        CACHE_RESP_PERIOD = os.environ.get(
+            "CACHE_SHORT_INV_PERIOD", CACHE_RESP_PERIOD)
         # Sentry configuration (optional)
-        SENTRY_DSN = os.environ.get("SENTRY_DSN") or ""
+        SENTRY_DSN = os.environ.get("SENTRY_DSN", "")
         SENTRY_TRACES_SAMPLE_RATE = float(
-            os.environ.get("SENTRY_TRACES_SAMPLE_RATE") or "1.0"
-        )
+            os.environ.get("SENTRY_TRACES_SAMPLE_RATE", "1.0"))
     except NameError:
         print("Missing environment variables.")
         raise