Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot show query result. #28

Closed
leeyaunlong opened this issue May 8, 2023 · 6 comments
Closed

Cannot show query result. #28

leeyaunlong opened this issue May 8, 2023 · 6 comments

Comments

@leeyaunlong
Copy link

leeyaunlong commented May 8, 2023

Chrome:102, copilot : 1.11.3
Save is work, icon will show correct saved item counts.
But click the icon, cannot show query result.

snap_20230508_160438_chrome

I checked service work log:
snap_20230508_155733_chrome

@EINDEX
Copy link
Owner

EINDEX commented May 8, 2023

Do you mind sharing block content here?

@leeyaunlong
Copy link
Author

since update to 1.11.3, the copilot will show some random issue.

  • cannot show capture page's content in popup window(like above screen shot)

  • the link cannot jump to logseq in popup window (in sometime will happen, but link is good, i can run it in window).
    for this case, the 4 links cannot jump to logseq, but it always workfine with old version.
    snap_20230509_090712_chrome

@leeyaunlong
Copy link
Author

Do you mind sharing block content here?
The url schema jump to logseq function work well at v1.11.0
Since v1.11.1 , thejump function failed.

@leeyaunlong
Copy link
Author

Do you mind sharing block content here?
If I right click the "to block" or "note" , select open in new tab , the copilot will trigger the logseq open correct location.

I guess the link added some custom event , cause the issue.

Final I find out the popup source :

        document.querySelectorAll('a').forEach((e) => {
          e.onclick = () => {
            connect.postMessage({
              type: 'open-page',
              url: e.href,
            });
            window.close();
          };

If I remove the click event at those type link , will work well.

@pstuifzand
Copy link

I was just looking at this and saw that the 'open-page' message was logged by this line, instead of the other message handler. Perhaps this helps with debugging the problem further?

@EINDEX EINDEX closed this as completed in 61502d5 May 11, 2023
EINDEX added a commit that referenced this issue May 11, 2023
Signed-off-by: EINDEX <snowstarlbk@gmail.com>
@EINDEX
Copy link
Owner

EINDEX commented May 11, 2023

Thanks for your information, which help me fix this issue!

The fix version on v1.11.4 will release on the store soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants