Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyright clarifications #90

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@arcuri82
Copy link
Collaborator

commented Sep 18, 2019

No description provided.

@arcuri82 arcuri82 requested a review from jgaleotti Sep 18, 2019
README.md Show resolved Hide resolved
@@ -236,6 +236,25 @@ in submodules can lead to duplicated `<version>` declarations with different ver
All version numbers should be easily audited, and so should be in a single file (i.e., the
*root* `pom.xml`).
### THIRD-PARTY LIBRARIES

This comment has been minimized.

Copy link
@jgaleotti

jgaleotti Sep 18, 2019

Collaborator

One of the libraries used by the regex distance code has BSD license, would that be compatible?

This comment has been minimized.

Copy link
@arcuri82

arcuri82 Sep 18, 2019

Author Collaborator

As far as I know, only GPL is a problem. other OS licenses are usually fine

These classes will be removed when this [PR](https://github.com/junit-team/junit5/issues/1947)
will be part of the next JUnit release.


This comment has been minimized.

Copy link
@jgaleotti

jgaleotti Sep 18, 2019

Collaborator

Understood, I will add any class added to the code directly here once this PR is merged into master.

This comment has been minimized.

Copy link
@arcuri82

arcuri82 Sep 18, 2019

Author Collaborator

if you approve these clarifications, and require no further info, you can just go ahead and merge ;)

@jgaleotti jgaleotti merged commit dde5591 into master Sep 18, 2019
2 of 3 checks passed
2 of 3 checks passed
ci/circleci: build Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@arcuri82 arcuri82 deleted the license-clarifications branch Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.