From 6317b7b5b87dafb53ce4d1df49b404a98e8e3367 Mon Sep 17 00:00:00 2001 From: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Date: Tue, 28 Sep 2021 11:05:27 +0200 Subject: [PATCH] Fix connect loc not respecting phasing in some cases when it should (#61698) --- code/game/machinery/doors/firedoor.dm | 2 ++ code/game/machinery/doors/windowdoor.dm | 2 ++ code/game/objects/structures/windoor_assembly.dm | 3 +++ code/game/objects/structures/window.dm | 3 +++ code/modules/ruins/objects_and_mobs/necropolis_gate.dm | 3 +++ 5 files changed, 13 insertions(+) diff --git a/code/game/machinery/doors/firedoor.dm b/code/game/machinery/doors/firedoor.dm index ce69693fd2046e..0ab8c87aa5ffb3 100644 --- a/code/game/machinery/doors/firedoor.dm +++ b/code/game/machinery/doors/firedoor.dm @@ -279,6 +279,8 @@ /obj/machinery/door/firedoor/border_only/proc/on_exit(datum/source, atom/movable/leaving, direction) SIGNAL_HANDLER + if(leaving.movement_type & PHASING) + return if(leaving == src) return // Let's not block ourselves. diff --git a/code/game/machinery/doors/windowdoor.dm b/code/game/machinery/doors/windowdoor.dm index 7e224978e08055..b9b0bedc9da56a 100644 --- a/code/game/machinery/doors/windowdoor.dm +++ b/code/game/machinery/doors/windowdoor.dm @@ -140,6 +140,8 @@ /obj/machinery/door/window/proc/on_exit(datum/source, atom/movable/leaving, direction) SIGNAL_HANDLER + if(leaving.movement_type & PHASING) + return if(leaving == src) return // Let's not block ourselves. diff --git a/code/game/objects/structures/windoor_assembly.dm b/code/game/objects/structures/windoor_assembly.dm index bc3c1b241938a6..aca98f7ae8f51f 100644 --- a/code/game/objects/structures/windoor_assembly.dm +++ b/code/game/objects/structures/windoor_assembly.dm @@ -77,6 +77,9 @@ /obj/structure/windoor_assembly/proc/on_exit(datum/source, atom/movable/leaving, direction) SIGNAL_HANDLER + if(leaving.movement_type & PHASING) + return + if(leaving == src) return // Let's not block ourselves. diff --git a/code/game/objects/structures/window.dm b/code/game/objects/structures/window.dm index c51fa0ff821fa7..b1aea45fc9d722 100644 --- a/code/game/objects/structures/window.dm +++ b/code/game/objects/structures/window.dm @@ -127,6 +127,9 @@ /obj/structure/window/proc/on_exit(datum/source, atom/movable/leaving, direction) SIGNAL_HANDLER + if(leaving.movement_type & PHASING) + return + if(leaving == src) return // Let's not block ourselves. diff --git a/code/modules/ruins/objects_and_mobs/necropolis_gate.dm b/code/modules/ruins/objects_and_mobs/necropolis_gate.dm index 18297126af7b30..49a1fefa40c3ba 100644 --- a/code/modules/ruins/objects_and_mobs/necropolis_gate.dm +++ b/code/modules/ruins/objects_and_mobs/necropolis_gate.dm @@ -70,6 +70,9 @@ /obj/structure/necropolis_gate/proc/on_exit(datum/source, atom/movable/leaving, direction) SIGNAL_HANDLER + if(leaving.movement_type & PHASING) + return + if(leaving == src) return // Let's not block ourselves.