Implement Search #17
Merged
Implement Search #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @sharmaaditya570191 can you check the functionality once? |
kaybhutani
reviewed
Jun 19, 2021
kaybhutani
reviewed
Jun 19, 2021
|
everything else looks good |
kaybhutani
reviewed
Jun 19, 2021
| }, | ||
| { cancelToken: cancelToken.current.token } | ||
| ) | ||
| setUsersToSuggest(response.data.data.users) |
kaybhutani
reviewed
Jun 19, 2021
| } else { | ||
| setUsersToSuggest([]) | ||
| } | ||
| }, [userTerm, setUsersSuggestionOpen]) |
There was a problem hiding this comment.
do we really need this? these are props and components will re-render anyway on props change
There was a problem hiding this comment.
I think yes, because of setUsersToSuggest(response.data.data.users) if we remove the dependencies then, it will be rendered again & again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Basic implementation of the search functionality.
search2.mp4
For this to work we need to enable the
findpermission inPublic > Users Permissions > User