Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Pretty print transactions #4112

Merged
merged 3 commits into from Jun 15, 2018
Merged

Pretty print transactions #4112

merged 3 commits into from Jun 15, 2018

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Jun 14, 2018

Enhanced the abi_serializer to be able to deserialize transactions even if they have invalid abi set on the contract. So even with invalid abi the transaction can still be pretty-printed. In the case of invalid abi the action data is left in hex since there is no way to deserialize it. This allows indexers like the mongodb plugin to serialize the parts of transaction that are serializable without the user provided abi.

I suspect this will fix issue #4111 that was just submitted.

@heifner heifner requested a review from arhag June 14, 2018 23:33
@arhag arhag added this to the Version 1.0.4 milestone Jun 15, 2018
@heifner heifner merged commit 24b9862 into master Jun 15, 2018
@heifner heifner deleted the abi-recursion branch June 15, 2018 02:24
@jawadhaxan007
Copy link

@heifner My issue is still there. issue#4111
This is the error I'm getting:
Invalid packed transaction
pivot != std::string::npos: No delimiter in string, cannot determine type: EOSK59ovuuemzcGX1QKATF4pEVg2AmUT2rjQAH8MrC52SpmBZ59YPVYMFYTBg7XNgCDQcX18vMyDsjEp4SbyDnkcUvruZ94BX
Failed to deserialize variant

@jawadhaxan007
Copy link

This is the command I'm using and getting error:
cleos -H node1.eosphere.io --wallet-host localhost --wallet-port 8888 set contract eosuser build/contracts/eosio.token -p eosuser

Getting same error for every contract

cleos version client: 15953cc

Please, help me to fix this.
Thanks

@jawadhaxan007
Copy link

@heifner The problem is coming from here /eos/libraries/fc/src/crypto/signature.cpp:
const auto pivot = base58str.find('_');
FC_ASSERT(pivot != std::string::npos, "No delimiter in string, cannot determine type: ${str}", ("str", base58str));

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants