New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return transaction_trace even if unable to serialize the action_trace… #5260

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
2 participants
@heifner
Contributor

heifner commented Aug 15, 2018

Resolves #4349

  • Return transaction_trace even if unable to serialize the action_trace action data

This prevents reporting a failure for a push_transaction even though the transaction succeeded because of not being able to serialize the transaction_trace in the abi_serializer time out.

@heifner heifner requested a review from wanderingbort Aug 15, 2018

@heifner heifner changed the base branch from develop to release/1.2.x Aug 22, 2018

@wanderingbort wanderingbort merged commit 75035c9 into release/1.2.x Aug 22, 2018

14 checks passed

buildkite/eosio Build #2946 passed (35 minutes, 8 seconds)
Details
buildkite/eosio/aws-build Passed (10 minutes, 11 seconds)
Details
buildkite/eosio/aws-tests Passed (19 minutes, 1 second)
Details
buildkite/eosio/centos-build Passed (11 minutes, 13 seconds)
Details
buildkite/eosio/centos-tests Passed (18 minutes, 56 seconds)
Details
buildkite/eosio/darwin-build Passed (7 minutes, 58 seconds)
Details
buildkite/eosio/darwin-tests Passed (22 minutes, 15 seconds)
Details
buildkite/eosio/fedora-build Passed (12 minutes, 35 seconds)
Details
buildkite/eosio/fedora-tests Passed (19 minutes, 52 seconds)
Details
buildkite/eosio/pipeline Passed (3 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-build Passed (10 minutes, 26 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-tests Passed (19 minutes, 4 seconds)
Details
buildkite/eosio/ubuntu-build Passed (8 minutes, 43 seconds)
Details
buildkite/eosio/ubuntu-tests Passed (19 minutes, 31 seconds)
Details

@heifner heifner deleted the gh#4349-push-transaction branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment