New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer logging fix #5286

Merged
merged 4 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@heifner
Contributor

heifner commented Aug 16, 2018

  • Fixed access to pending_block_state when not available.
  • Cleanup some logging.
  • Added some sanity checks for pending_block_state.
@@ -931,8 +931,10 @@ producer_plugin_impl::start_block_result producer_plugin_impl::start_block(bool
if (_pending_block_mode == pending_block_mode::speculating) {
auto head_block_age = now - chain.head_block_time();
if (head_block_age > fc::seconds(5))
if (head_block_age > fc::seconds(5)) {
fc_dlog(_log, "Greater than 5 secs behind, waiting");

This comment has been minimized.

@brianjohnson5972

brianjohnson5972 Aug 16, 2018

Contributor

Will this give us any more information than the log statement "Waiting till another block is ..." which will be printed out in producer_plugin_impl::schedule_production_loop?

This comment has been minimized.

@heifner

heifner Aug 16, 2018

Contributor

Good point, I'll remove it.

heifner added some commits Aug 16, 2018

@heifner heifner merged commit 7ee4659 into release/1.2.x Aug 22, 2018

14 checks passed

buildkite/eosio Build #2964 passed (34 minutes, 37 seconds)
Details
buildkite/eosio/aws-build Passed (10 minutes, 28 seconds)
Details
buildkite/eosio/aws-tests Passed (19 minutes, 43 seconds)
Details
buildkite/eosio/centos-build Passed (11 minutes, 1 second)
Details
buildkite/eosio/centos-tests Passed (19 minutes, 36 seconds)
Details
buildkite/eosio/darwin-build Passed (7 minutes, 39 seconds)
Details
buildkite/eosio/darwin-tests Passed (21 minutes, 37 seconds)
Details
buildkite/eosio/fedora-build Passed (12 minutes, 40 seconds)
Details
buildkite/eosio/fedora-tests Passed (18 minutes, 38 seconds)
Details
buildkite/eosio/pipeline Passed (4 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-build Passed (8 minutes, 49 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-tests Passed (18 minutes, 46 seconds)
Details
buildkite/eosio/ubuntu-build Passed (8 minutes, 23 seconds)
Details
buildkite/eosio/ubuntu-tests Passed (19 minutes, 26 seconds)
Details

@heifner heifner deleted the producer-fix branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment